jdavidberger

Results 54 comments of jdavidberger

If that is what is wanted UI-wise, I'd consider removing the clear behavior from dbggetdbgevents altogether, and let the widget itself handle the logic by tracking time between updates and...

Sure, but at no point do you have an exact counter right now -- it is clearing itself, and at some points is doing so within 50ms of the last...

Fixed the dbggetdbgevents functionality. You can now click the time wasted widget and it will swap between view modes; although these still only work when events are coming in. Default...

I believe everything is resolved now; and it should be ready to merge in.

I've added similar customization parameters to SynthesizeModelFrame. Depending on the feedback on whether to keep binary compatibility vs simplify the code I'll make it match whatever is wanted for that.

The function declarations in the pybind were missing; I'm guessing just got typoed out. I added those back in and it builds and works.

Is there anything more I need to do for this pr?

I also added a commit to store the allocated buffer to avoid a re-allocation for that fragment buffer each call into raycast

The main issue with this is thread safety. As is it's not particularly thread safe but if you lock properly around the VoxelGrid it would be; here if you have...

Is there anything more I need to do in this and #5304 to get them merged or is it still in review?