Open3D icon indicating copy to clipboard operation
Open3D copied to clipboard

Add default parameters in slam::Model cpp.

Open jdavidberger opened this issue 2 years ago • 6 comments

This seemed like an active todo and it would be useful for me to have these levers in the python code.


This change is Reviewable

jdavidberger avatar Jul 11 '22 22:07 jdavidberger

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

update-docs[bot] avatar Jul 11 '22 22:07 update-docs[bot]

I've added similar customization parameters to SynthesizeModelFrame. Depending on the feedback on whether to keep binary compatibility vs simplify the code I'll make it match whatever is wanted for that.

jdavidberger avatar Jul 18 '22 00:07 jdavidberger

Thanks for your contributions @jdavidberger, I will try to check this and get back to you by this weekend.

reyanshsolis avatar Jul 18 '22 19:07 reyanshsolis

The functionality you wanted to achieve, could be done using default params instead of overloading functions. Previously, the default values were present in pybind but missing in cpp, so I have added the changes accordingly to this PR and tested the cpp slam system example.

May you please try the update and check if your code is working as well?

reyanshsolis avatar Jul 25 '22 10:07 reyanshsolis

The function declarations in the pybind were missing; I'm guessing just got typoed out. I added those back in and it builds and works.

jdavidberger avatar Jul 25 '22 16:07 jdavidberger

Is there anything more I need to do for this pr?

jdavidberger avatar Aug 09 '22 13:08 jdavidberger

Is there anything more I need to do for this pr? I don't think so. The PR looks good to merge. Thanks for your contribution.

reyanshsolis avatar Aug 11 '22 21:08 reyanshsolis