Julien Couvreur comments

Results 152 comments of


                                            Julien Couvreur

Fix line breaks between members when a property has an initializer

/azp run

Fix line breaks between members when a property has an initializer

@DoctorKrolic We've had some CI issues. Could you merge latest bits from the `main` branch into this PR? (I do `git fetch origin main` then `git merge origin/main` then push...

Fix line breaks between members when a property has an initializer

Thanks for the contribution @DoctorKrolic!

Suppress Warning CS6800 when the System Type.GetType(..) method's parameter throwOnError (bool) contains a true value

Thanks @Youssef1313 Closing as duplicate of https://github.com/dotnet/csharplang/issues/2835

Incorporate underlying type's hierarchy into overload resolution

@jjonescz @dotnet/roslyn-compiler for second review. Thanks

False nullability warnings for delegate conversions

Nullability attributes do factor in delegate conversion. Below is an example with conversion of lambda to delegate type. So the example in OP seems a bug. FWIW, the logic lives...

Patterns: Allow non-negative and full integer sets to merge (intersect or union)

@alrz Thanks much for the suggestion. I'd not considered that. I'll give it a try (seems simpler).

Patterns: Allow non-negative and full integer sets to merge (intersect or union)

@alrz I took a stab at it, but I don't think tweaking the comparison is a good approach after all. It's better for all branches of the DAG that test...

Patterns: Allow non-negative and full integer sets to merge (intersect or union)

> Curious why we don't think of that as special. I assumed we were using `.Count` from teh highest interface, not _just_ IList. `ICollection` lacks an indexer (it could not...

Patterns: Allow non-negative and full integer sets to merge (intersect or union)

Clarified offline with @CyrusNajmabadi. Independently of the change in this PR, he's surprised that we don't make the non-negative assumption of well-behavedness for some other well-known BCL `Count` properties such...