Julien Couvreur

Results 152 comments of Julien Couvreur

@paul1956 The default project setting (which most people keep, since it's the default) is LangVersion = `default`. That means "latest major version". If you want to change your project to...

If LangVersion doesn't appear in the project file, you can check its effective value by running msbuild with option '/bl' (which produces a binary/structured log, see "msbuild structured log viewer")....

> // (3,1): hidden CS8019: Unnecessary using directive. Test `AsyncWithEH`, line 150: Do we understand what API we used for async that we no longer use for runtime-async? --- Refers...

> [G]: Unexpected type on the stack. { Offset = 0x104, Found = Int32, Expected = ref 'System.Threading.Tasks.Task`1' } Test `AsyncWithEHCodeQuality`, line 587: Did we file an issue on ILVerify...

> verifier.VerifyDiagnostics( nit: Test `AsyncWithException1`, line 690: Consider also verifying diagnostics on the async baseline above, and possibly removing the `async` from `F` Also applies to some other tests below...

> IL_0145: ldnull nit: Thanks for pointing out this test. Consider leaving a comment for what to look for in the IL (this is an async test where the new...

> verifier.VerifyIL("Test.G(System.Threading.SemaphoreSlim)", """ Test `AsyncInFinally006_AsyncVoid_01`, line 2059 (last VerifyIL): Was there anything in particular to observe here? This should not have been affected by the change in this PR, right?...

There is a remaining workitem to update the language spec to reflect this feature. That's why the issue is kept open.

@bondsbw Yes, that's what I'd have in mind. The local function would not be able to access variables from parent method or instance fields. It could only access variables that...