Julien Couvreur
Julien Couvreur
@copilot Remove IsEmbedded. It is redundant with FileName and we need FileName for non-embedded scenarios
@copilot We don't need to include ruleSet in the key after all since it can only affect the compilation output via GeneralDiagnosticOption and SpecificDiagnosticOptions. Both of those are already included...
@copilot Let's update the added test for resources to include a non-public resource and a non-embedded resource. Also, let's add a test showing that irrelevant/trivial changes to ruleset does not...
I'm investigating the determinism failure in CI with `Microsoft.VisualStudio.Extensibility.Testing.Xunit`: ```diff ... "resources": [ { "resourceName": "Microsoft.VisualStudio.IntegrationTestService.dll", "fileName": null, "isPublic": true, "content": { "checksum": "da3a9f2c2fc2de2bf0254f9f13e15726c7a260ab318acff9a77790ccc344a", "checksumAlgorithm": "Sha256" } }, { "resourceName":...
Tagging @333fred to advise/triage.
> It looks like the speclet says nothing about consumption scenarios Yes, the speclet was not yet updated. > Corresponding spec is incoming. Some notable choices (will confirm with LDM):...
> It looks like the speclet says nothing about consumption scenarios Here's the corresponding PR to update the spec: https://github.com/dotnet/csharplang/pull/9869 #Resolved
> _ = d[0]; I think that's `Dynamic_01` above --- In reply to: [3640424908](https://github.com/dotnet/roslyn/pull/81607#issuecomment-3640424908) [](http://example.com/codeflow?ancestors=3640424908) --- Refers to: src/Compilers/CSharp/Test/CSharp15/ExtensionIndexersTests.cs:4903 in f504f6e. [](commit_id = f504f6e6de42a4f46019b92ab8913e3be6c2920e, deletion_comment = False)
> // Irregular/legacy behavior for indexer arguments For indexers, we skip the safety check for usage of pointer type. Extension indexers carry over the same behavior as non-extension indexers. I'll...
> public void RefAnalysis_Indexing_01() I used existing and modified ref analysis tests for extension methods --- In reply to: [3640438499](https://github.com/dotnet/roslyn/pull/81607#issuecomment-3640438499) [](http://example.com/codeflow?ancestors=3640438499) --- Refers to: src/Compilers/CSharp/Test/CSharp15/ExtensionIndexersTests.cs:5019 in f504f6e. [](commit_id = f504f6e6de42a4f46019b92ab8913e3be6c2920e,...