Jonathan Bluett-Duncan

Results 425 comments of Jonathan Bluett-Duncan

I rebased this PR over main earlier this afternoon (as I saw that the Asciidoc code snippets work was merged in recently), and then I worked on documenting how to...

@nipafx Perfect, thank you! I've pencilled in some more time to work on the docs this weekend. I'll get there. Eventually. :smile:

> It just occurred to me, I don't think sharing and arguments work well together. If shared resource "Foo" is first referenced without arguments and later with one, then there's...

@nipafx @Michael1993 @beatngu13 I am finally ready for a proper review! 🎉 Sorry in advance for the enormous PR. I'm not sure how it can be split into easier-to-review parts,...

@nipafx Thank you very much for such a thorough review! I've found the time to review some of your comments this evening, and I hope to have time to review...

@nipafx I got around to addressing even more of your feedback this evening. See https://github.com/junit-pioneer/junit-pioneer/pull/491#discussion_r953079152 and https://github.com/junit-pioneer/junit-pioneer/pull/491#discussion_r953109683. I don't suppose you've had time to look at my answers to your...

@nipafx I believe I've now addressed all your current feedback. If you find the time to review this further, please let me know if you have any questions about my...

> Hey @jbduncan sorry for pushing so much stuff on your branch, I'm just trying to make it work with our modular setup because I felt it would be unfair...

As a side note, we might want to name the annotation `@ResourceRead` something like `@ClasspathResource` (or `@ModulePathResource`?), because my [ongoing](https://github.com/junit-pioneer/junit-pioneer/issues/348) [work](https://github.com/junit-pioneer/junit-pioneer/pull/491) will introduce another concept which so far is also...

@Michael1993 Thanks for labelling this issue (even though it's still "in discussion") and for assigning me!