Jonathan Bluett-Duncan comments

Results 425 comments of


                                            Jonathan Bluett-Duncan

Remove the slf4j-simple dependency, as we use Flogger

My guess based on my limited understanding is that the slf4j-simple artifact should be unneeded if (1) we decide to switch Flogger's backend from what it is currently (JUL or...

Remove the slf4j-simple dependency, as we use Flogger

@oferb Yeah, that all makes sense to me. I realise that I've said this already, but I believe that if/once a backend logging framework for Flogger other than JUL is...

Remove the slf4j-simple dependency, as we use Flogger

Hmm. It occurs to me that for log4j2 or logback to be used as the backend for Flogger, either of these issues on the Flogger issue tracker will need to...

Remove the slf4j-simple dependency, as we use Flogger

(IMO, log4j2 and logback are perfectly reasonable replacements for JUL, which is why I mentioned them as potential backends for Flogger in my last comment.)

Remove the slf4j-simple dependency, as we use Flogger

I think the only reason we'd want to do it so far is so that we can ultimately remove the dependency on slf4j-simple (it feels strange to me that we...

Introduce mechanism for inter-test dependencies

This issue still sounds potentially useful as an extension to #48.

Add OptionalSubject.hasValueThat() (which returns a Subject)

I personally love the idea of `assertThat(optional).hasValueThat().isSameAs(object);`. :)

Consider adding `StringSubject.containsAll([String...|Iterable<String>])`

Hi @cpovirk, many thanks for spending time to write up a well-thought response! My current implementation just does multiple `contains` calls, as that was what I was personally after and...

Introduce mechanism for programmatic extension management

This issue still seems useful to have around.

Decide how to report 'unexpected' and 'actual' values in an exception

FYI, [Google Truth](https://github.com/google/truth) produces IMO rather nice error messages that show how `actual` and `expected` differ to each other if they are both strings. Perhaps their error message format could...