Jonathan Bluett-Duncan
Jonathan Bluett-Duncan
I've decided to not include the before-mentioned `@Singleton` annotation, because I'm not sure if I'll have time to implement it on top of the rest of the proposal.
In response to feedback during hack.commit.push, here's my latest proposal! Git diff: https://github.com/jbduncan/junit-pioneer/commit/22ed80ce7b4e0e757124e50b2d03b41b95109677 Entire Git branch: https://github.com/junit-pioneer/junit-pioneer/compare/main...jbduncan:issue/348-temp-dir-extension
For posterity, I discussed @nipafx's proposal above with him over his Twitch stream, and I'm happy to give it a shot!
I've just created a draft PR with my ongoing work: https://github.com/junit-pioneer/junit-pioneer/pull/491 Even though it's a draft, feedback is very much welcome.
Real life commitments are getting in the way of me progressing with this issue right now, so I'll let you know when I've found the time to work on this...
As a future note for myself, it looks like JUnit 5 has a [`CloseableResource`](https://github.com/junit-team/junit5/blob/43638eb6a870e0d6c49224053dfeb39dcf0ef33f/junit-jupiter-api/src/main/java/org/junit/jupiter/api/extension/ExtensionContext.java#L405) type that I could reuse as part of my work over at https://github.com/junit-pioneer/junit-pioneer/pull/491. It looks safe...
Note for myself: I thought at some point that `@Share` and `@Shared` were redundant, because I can adapt the following example: ```java @ExtendWith(ResourceManager.class) @Share(name = "aClassWideTempDirectory", value = TemporaryDirectory.class) class...
Here is my TODO list for my [PR](https://github.com/junit-pioneer/junit-pioneer/pull/491): - [x] I currently use `System::identityHashCode` to uniquely identify resources and resource factories, but this is [error-prone](https://github.com/plume-lib/plume-util/blob/ccdb37b4393bdbbc0087e3317b9a1d1b4827b78b/src/main/java/org/plumelib/util/UniqueIdMap.java) apparently, so use an atomic...
@nipafx Ah, I hadn't considered parallel execution yet! Thanks for starting this conversation. It's in the ever-growing [TODO list](https://github.com/junit-pioneer/junit-pioneer/issues/348#issuecomment-884922323) now, for me to think about or discuss later.
@nipafx I've been slowly, occasionally working on this over the past few months, and now I have a test error that I can't wrap my head around, and any guidance...