Jonathan Bluett-Duncan

Results 425 comments of Jonathan Bluett-Duncan

@nipafx I'll look into making `ResourceManagerExtension` thread-safe next. However, I've already spent a few months on this PR, and it seems to me that not all of the JUnit 5...

Great news, I've fixed [the illusive bug](https://github.com/junit-pioneer/junit-pioneer/issues/348#issuecomment-938925966)! So now the only thing I think I have to do is address the thread safety.

@nipafx Wow, thank you for the detailed review! I'm still very interested in working on this, I'm just held back by IRL things again and I don't know when I'll...

FYI, I've rebased all the commits in this PR on top of `main` as preparation to meta-annotate `@New` and `@Shared` with the `@Resources` annotation. This should make tests using `@New`/`@Shared`...

@Bukama The only things left to do are as follows: - Ensure that `@BeforeEach`/`@BeforeAll`/`@AfterEach`/`@AfterAll` methods annotated with `@Shared` are run sequentially. - Raise some new issues to: - Ensure that...

@nipafx Thanks for following up on this! I believe all the changes we worked on together are now on [GitHub](https://github.com/junit-pioneer/junit-pioneer/pull/491/commits/bab15506ed0d2e0346535aa98d849236d75d7525). I saw https://github.com/junit-pioneer/junit-pioneer/issues/141 in my inbox recently, and I agree...

@nipafx @Bukama This PR is _finally_ ready for review! :tada: Let me know what you think.

> Great PR, this going really well. I didn't review all of it, yet, but I made a bunch of small changes ☝🏾 and comments 👇🏾. Will have to continue...

@nipafx Yep, IRL things kept me away again, but I should be able to dedicate some time this weekend. :)

@nipafx Apologies, I wasn't able to dedicate any time to this PR this weekend after all due to more IRL things. Not sure when I'll next have time, but I've...