jasp-desktop

jasp-desktop copied to clipboard

Translations update from Hosted Weblate

[]

Translations update from [Hosted Weblate](https://hosted.weblate.org) for [JASP/jaspDesktop](https://hosted.weblate.org/projects/jasp/jaspdesktop/). Current translation status: 

weblate

Almost fixes weird font in windows results

[{"_id":"634a9ac2622e8405e37cec7a","body":"This is done by simply trying to compensate for any fractional `x` value","issue_id":1660519580426,"origin_id":1212030534,"user_origin_id":29062713,"create_time":1660226452,"update_time":1660226452,"id":1665833666965,"updated_at":"2022-10-15T11:34:26.965000Z","created_at":"2022-10-15T11:34:26.965000Z"}]

Fixes https://github.com/jasp-stats/jasp-issues/issues/1747 mostly You can still get it to look slightly weird if you try but it seems to usually get it right now

JorisGoosen

Changes to building guide

[]

- more specific instructions for adding GITHUB_PAT in Qt creator - updated image for change listed above

DanaJohanna

Fixes for normalized notation

[]

- preferencesModel changes werent connect to results, this is fixed now. fixes https://github.com/jasp-stats/INTERNAL-jasp/issues/1872 - also renamed the checkbox to "Use exponent notation" - made using normalized notation the default

JorisGoosen

Data library updates

[{"_id":"634aa191622e8405e37cf1d6","body":"Thanks, I will add the suggestions.\r\n\r\nWhat do you prefer? Adding the other library files here or in a new PR?","issue_id":1660519580434,"origin_id":1209328968,"user_origin_id":38475991,"create_time":1660048751,"update_time":1660048751,"id":1665835409662,"updated_at":"2022-10-15T12:03:29.661000Z","created_at":"2022-10-15T12:03:29.661000Z"},{"_id":"634aa191622e8405e37cf1d7","body":"Here is fine :)","issue_id":1660519580434,"origin_id":1209349062,"user_origin_id":7093546,"create_time":1660049871,"update_time":1660049871,"id":1665835409664,"updated_at":"2022-10-15T12:03:29.664000Z","created_at":"2022-10-15T12:03:29.664000Z"},{"_id":"634aa191622e8405e37cf1d8","body":"I changed the title, added a description to some of the variables, and I removed other variables that I did not want to spend time figuring out and describing :)","issue_id":1660519580434,"origin_id":1238087144,"user_origin_id":38475991,"create_time":1662467514,"update_time":1662467514,"id":1665835409667,"updated_at":"2022-10-15T12:03:29.667000Z","created_at":"2022-10-15T12:03:29.667000Z"}]

So, I have a few JASP analyses that could be added to the JASP library. First, I'm adding this one to the mixed models, if the PR looks good, I...

FBartos

More feedback in column tooltip

[]

Implements requests from https://github.com/jasp-stats/jasp-issues/issues/1720

JorisGoosen

Replaced the `KeyNavigation.KeyUp` and `.KeyDown` with `tab` and `backTab`

[{"_id":"634a9ba4622e8405e37ced12","body":"All the KeyNavigation,backtab and KeyNavigation.tab can be in fact removed. The QML engine is clever enough to find the next or previous control.","issue_id":1660519580451,"origin_id":1009909886,"user_origin_id":503332,"create_time":1641903473,"update_time":1641903473,"id":1665833892195,"updated_at":"2022-10-15T11:38:12.195000Z","created_at":"2022-10-15T11:38:12.195000Z"},{"_id":"634a9ba4622e8405e37ced13","body":"That's what I was hoping but I'm not sure if that's the case in different platforms. I still cannot do a lot of the keyboard navigation on my Mac, and if you remember we discussed this when I showed it to you. I don't know what's the case, but it's not working everywhere.","issue_id":1660519580451,"origin_id":1009912105,"user_origin_id":1290841,"create_time":1641903647,"update_time":1641903647,"id":1665833892199,"updated_at":"2022-10-15T11:38:12.199000Z","created_at":"2022-10-15T11:38:12.199000Z"},{"_id":"634a9ba4622e8405e37ced14","body":"> That's what I was hoping but I'm not sure if that's the case in different platforms. I still cannot do a lot of the keyboard navigation on my Mac, and if you remember we discussed this when I showed it to you. I don't know what's the case, but it's not working everywhere.\r\n\r\nI will try it tomorrow on my PC-Windows at the UvA.\r\nI have also removed in another PR the period in 'Help us translate or improve JASP in your language.' You have now conflicts, but you just has to remove the files from your PR.","issue_id":1660519580451,"origin_id":1010010712,"user_origin_id":503332,"create_time":1641910880,"update_time":1641910880,"id":1665833892202,"updated_at":"2022-10-15T11:38:12.201000Z","created_at":"2022-10-15T11:38:12.201000Z"},{"_id":"634a9ba4622e8405e37ced15","body":"Resolved the conflict! \ud83d\udc4d\ud83c\udffc ","issue_id":1660519580451,"origin_id":1010775487,"user_origin_id":1290841,"create_time":1641976602,"update_time":1641976602,"id":1665833892204,"updated_at":"2022-10-15T11:38:12.204000Z","created_at":"2022-10-15T11:38:12.204000Z"}]

Fixes https://github.com/jasp-stats/INTERNAL-jasp/issues/728 and fixes https://github.com/jasp-stats/INTERNAL-jasp/issues/1653 I tweaked the SpinBox just enough that it doesn't mess up with the navigation. It works much more predictable now. There are more to fix...

amirmasoudabdol

Improvement to the MessageBoxes

[{"_id":"634a9fe512161256306194a7","body":"To me the \"Would you\" construction works, but if prefer what microsoft does, then that's fine as well. ","issue_id":1660519580455,"origin_id":940747143,"user_origin_id":10271675,"create_time":1634024301,"update_time":1634024301,"id":1665834981760,"updated_at":"2022-10-15T11:56:21.759000Z","created_at":"2022-10-15T11:56:21.759000Z"},{"_id":"634a9fe512161256306194a8","body":"Let's go with the \"Would you\" then!","issue_id":1660519580455,"origin_id":940748734,"user_origin_id":1290841,"create_time":1634024446,"update_time":1634024446,"id":1665834981763,"updated_at":"2022-10-15T11:56:21.763000Z","created_at":"2022-10-15T11:56:21.763000Z"},{"_id":"634a9fe512161256306194a9","body":"@boutinb I see that to fix this properly, I need to change a few strings, and as you said this might make it tricky for the translators. I think I continue working on it, but we merge it after 0.16.1 that there is enough time for the translators to catch up. Is that a good idea?","issue_id":1660519580455,"origin_id":1008865401,"user_origin_id":1290841,"create_time":1641820655,"update_time":1641820655,"id":1665834981766,"updated_at":"2022-10-15T11:56:21.766000Z","created_at":"2022-10-15T11:56:21.766000Z"},{"_id":"634a9fe512161256306194aa","body":"Yes there is no need to implement this in 0.16.1","issue_id":1660519580455,"origin_id":1008911040,"user_origin_id":503332,"create_time":1641823969,"update_time":1641823969,"id":1665834981769,"updated_at":"2022-10-15T11:56:21.768000Z","created_at":"2022-10-15T11:56:21.768000Z"},{"_id":"66433ecb2cfd0d66a80995d4","body":"Ok I rebased and updated the code to the current JASP version. But Im having trouble pushing to this branch.\r\nSo Ill open a new PR.","issue_id":1660519580455,"origin_id":1571814664,"user_origin_id":29062713,"create_time":1685616624,"update_time":1685616624,"id":1715683019766,"updated_at":"2024-05-14T10:36:59.765000Z","created_at":"2024-05-14T10:36:59.765000Z"}]

I noticed this not so professional message, "There are unapplied changes to your filter; what would you like to do?", and while looking into that, I ended up improving the...

amirmasoudabdol

Improvement to TextField Implementation

[{"_id":"634a9d16d843da038463b62b","body":"Maybe it does not work on other system Linux, but on my Mac Mojave I get the right alignment (with the original TextField code):\r\n<img width=\"238\" alt=\"Screenshot 2021-09-27 at 08 52 04\" src=\"https:\/\/user-images.githubusercontent.com\/503332\/134858675-7f24800c-4f49-4cc1-8ced-f619fe39cbec.png\">\r\nThere exists already a mechanism so that if several TextFields are onder a Group, the field part is aligned (cf _alignTextFields function). But I agree this is quite an awkward solution, and apparently it does not work well on all platforms.\r\nBut if I try your solution, it does not work either. For example if the label is a bit bigger then it's not aligned anymore:\r\n<img width=\"224\" alt=\"Screenshot 2021-09-27 at 09 25 59\" src=\"https:\/\/user-images.githubusercontent.com\/503332\/134863276-966d5a0f-58f2-4c86-a958-ac0391798417.png\">\r\nThis works with my awkward solution on my Mac:\r\n<img width=\"246\" alt=\"Screenshot 2021-09-27 at 09 29 12\" src=\"https:\/\/user-images.githubusercontent.com\/503332\/134863543-02e5ef46-6148-4eb3-891b-b6551b9fec57.png\">\r\nSo I think we should brainstorm together to see how to solve correctly this problem.\r\n\r\n","issue_id":1660519580458,"origin_id":927607189,"user_origin_id":503332,"create_time":1632727870,"update_time":1632727870,"id":1665834262742,"updated_at":"2022-10-15T11:44:22.742000Z","created_at":"2022-10-15T11:44:22.742000Z"},{"_id":"634a9d16d843da038463b62c","body":"Yes, my solution isn't perfect either, it only takes care of one of the case. Like you said, we need to think about this a bit more, and find a general solution for it. Then, we really need to force it that people \u2014outside of us\u2014 who design something for JASP, use them and we end up having a consistence interface.","issue_id":1660519580458,"origin_id":927615397,"user_origin_id":1290841,"create_time":1632728713,"update_time":1632728713,"id":1665834262746,"updated_at":"2022-10-15T11:44:22.746000Z","created_at":"2022-10-15T11:44:22.746000Z"}]

I has some time this morning, and I thought, oh, let's look around the UI a bit. I ended up looking into the `TextField`, `DoubleField`, and some other UI elements,...

amirmasoudabdol

Image resizer for JASP editor [DO NOT MERGE]

[{"_id":"634a9c79622e8405e37cedd4","body":"@akashrajkn could you get this branch back up to date so we can get it into 0.15?","issue_id":1660519580461,"origin_id":772453494,"user_origin_id":29062713,"create_time":1612353287,"update_time":1612353287,"id":1665834105882,"updated_at":"2022-10-15T11:41:45.881000Z","created_at":"2022-10-15T11:41:45.881000Z"},{"_id":"634a9c79622e8405e37cedd5","body":"The string translations could be done later.","issue_id":1660519580461,"origin_id":772453605,"user_origin_id":29062713,"create_time":1612353300,"update_time":1612353300,"id":1665834105885,"updated_at":"2022-10-15T11:41:45.885000Z","created_at":"2022-10-15T11:41:45.885000Z"},{"_id":"634a9c79622e8405e37cedd6","body":"Yes! I will do that ~today~ over the weekend","issue_id":1660519580461,"origin_id":773157560,"user_origin_id":6959308,"create_time":1612430324,"update_time":1612474091,"id":1665834105891,"updated_at":"2022-10-15T11:41:45.890000Z","created_at":"2022-10-15T11:41:45.890000Z"},{"_id":"634a9c79622e8405e37cedd7","body":"The weekend was quite long wasn't it? ;)","issue_id":1660519580461,"origin_id":777376921,"user_origin_id":29062713,"create_time":1613042395,"update_time":1613042395,"id":1665834105903,"updated_at":"2022-10-15T11:41:45.903000Z","created_at":"2022-10-15T11:41:45.903000Z"},{"_id":"634a9c79622e8405e37cedd8","body":"Can I test this and if it works merge it?","issue_id":1660519580461,"origin_id":777597288,"user_origin_id":29062713,"create_time":1613058911,"update_time":1613058911,"id":1665834105905,"updated_at":"2022-10-15T11:41:45.905000Z","created_at":"2022-10-15T11:41:45.905000Z"},{"_id":"634a9c79622e8405e37cedd9","body":"@JorisGoosen I am testing this right now, shall I get back to you in a few minutes?","issue_id":1660519580461,"origin_id":777600503,"user_origin_id":6959308,"create_time":1613059180,"update_time":1613059180,"id":1665834105908,"updated_at":"2022-10-15T11:41:45.907000Z","created_at":"2022-10-15T11:41:45.907000Z"},{"_id":"634a9c79622e8405e37cedda","body":"Well Im not in any hurry, let me know when I can check it out!\r\nI just thought that maybe the rebase was all you needed to do still ;)","issue_id":1660519580461,"origin_id":777604407,"user_origin_id":29062713,"create_time":1613059513,"update_time":1613059513,"id":1665834105910,"updated_at":"2022-10-15T11:41:45.910000Z","created_at":"2022-10-15T11:41:45.910000Z"},{"_id":"634a9c79622e8405e37ceddb","body":"> @JorisGoosen I am testing this right now, shall I get back to you in a few minutes?\r\n\r\nI tested it on Mac Catalina and it works as intended","issue_id":1660519580461,"origin_id":777673059,"user_origin_id":6959308,"create_time":1613065677,"update_time":1613065677,"id":1665834105912,"updated_at":"2022-10-15T11:41:45.912000Z","created_at":"2022-10-15T11:41:45.912000Z"},{"_id":"634a9c79622e8405e37ceddc","body":"> If you click outside quill however it stays in resizing-mode which looks a bit weird. Shouldnt Quill be unselected then and resizing stopped?\r\n\r\nNice catch! I will take a look at it. ","issue_id":1660519580461,"origin_id":779173197,"user_origin_id":6959308,"create_time":1613390111,"update_time":1613390111,"id":1665834105915,"updated_at":"2022-10-15T11:41:45.915000Z","created_at":"2022-10-15T11:41:45.915000Z"},{"_id":"634a9c79622e8405e37ceddd","body":"Ok nice!\r\n\r\nCould you also add the commit you used from https:\/\/github.com\/kensnyder\/quill-image-resize-module to the comment?\r\nThat way we can check in the future whether we need to update it or not.","issue_id":1660519580461,"origin_id":779181784,"user_origin_id":29062713,"create_time":1613391048,"update_time":1613391048,"id":1665834105917,"updated_at":"2022-10-15T11:41:45.917000Z","created_at":"2022-10-15T11:41:45.917000Z"},{"_id":"634a9c79622e8405e37cedde","body":"Update: This is an issue with the image resizer module ([link](https:\/\/github.com\/kensnyder\/quill-image-resize-module\/issues\/18)). The overlay is a new div element that is created when the image is clicked. This makes the editor lose focus. ","issue_id":1660519580461,"origin_id":797336573,"user_origin_id":6959308,"create_time":1615538963,"update_time":1615538963,"id":1665834105924,"updated_at":"2022-10-15T11:41:45.924000Z","created_at":"2022-10-15T11:41:45.924000Z"},{"_id":"634a9c79622e8405e37ceddf","body":"> Update: This is an issue with the image resizer module ([link](https:\/\/github.com\/kensnyder\/quill-image-resize-module\/issues\/18)). The overlay is a new div element that is created when the image is clicked. This makes the editor lose focus.\r\n\r\nWhich means you cannot fix it?\r\nWell, Im not sure what the repercussions would be from that...","issue_id":1660519580461,"origin_id":842203929,"user_origin_id":29062713,"create_time":1621246644,"update_time":1621246644,"id":1665834105929,"updated_at":"2022-10-15T11:41:45.929000Z","created_at":"2022-10-15T11:41:45.929000Z"},{"_id":"634a9c79622e8405e37cede0","body":"> Which means you cannot fix it?\r\nWell, Im not sure what the repercussions would be from that...\r\n\r\nI forked the module and made changes to fix this issue. (But it will not be done before v0.15 release)\r\nI will pick it up after I submit key navigation in analysis forms PR.","issue_id":1660519580461,"origin_id":842217515,"user_origin_id":6959308,"create_time":1621247990,"update_time":1621247990,"id":1665834105932,"updated_at":"2022-10-15T11:41:45.931000Z","created_at":"2022-10-15T11:41:45.931000Z"},{"_id":"634a9c79622e8405e37cede2","body":"I would love to see this feature merged. I could then transition away from ppt slides to jasp files dor my stats seminars.","issue_id":1660519580461,"origin_id":1133316651,"user_origin_id":4428185,"create_time":1653077682,"update_time":1653077682,"id":1665834105935,"updated_at":"2022-10-15T11:41:45.935000Z","created_at":"2022-10-15T11:41:45.935000Z"},{"_id":"634a9c79622e8405e37cede3","body":"@tomtomme I put this quite low on the priority list, so I didn't fix it for a while. I'll review it again sometime this month","issue_id":1660519580461,"origin_id":1133629717,"user_origin_id":6959308,"create_time":1653137729,"update_time":1653137740,"id":1665834105938,"updated_at":"2022-10-15T11:41:45.938000Z","created_at":"2022-10-15T11:41:45.938000Z"},{"_id":"634a9c79622e8405e37cede4","body":"Just wanted to say that this feature would still be massively useful :D","issue_id":1660519580461,"origin_id":1239025517,"user_origin_id":4428185,"create_time":1662536447,"update_time":1662536447,"id":1665834105941,"updated_at":"2022-10-15T11:41:45.941000Z","created_at":"2022-10-15T11:41:45.941000Z"},{"_id":"66433eb34ecfda50de0ed5ce","body":"Hi @akashrajkn @JorisGoosen Any news on the progress of this PR? if it can be pushed or someone picks it up, we will have series improvements for JASP note in the next release:-)","issue_id":1660519580461,"origin_id":1571900895,"user_origin_id":10348402,"create_time":1685620039,"update_time":1685620039,"id":1715682995850,"updated_at":"2024-05-14T10:36:35.849000Z","created_at":"2024-05-14T10:36:35.849000Z"},{"_id":"66433eb34ecfda50de0ed5cf","body":"@shun2wang There is still one issue with the image resizer module: \r\n\r\n> If you click outside quill however it stays in resizing-mode which looks a bit weird. Shouldnt Quill be unselected then and resizing stopped?\r\n\r\nThe github project (https:\/\/github.com\/kensnyder\/quill-image-resize-module) hasn't been updated since a few years, I think this issue still occurs. Can you take a look at it? ","issue_id":1660519580461,"origin_id":1571941691,"user_origin_id":6959308,"create_time":1685621558,"update_time":1685621558,"id":1715682995854,"updated_at":"2024-05-14T10:36:35.854000Z","created_at":"2024-05-14T10:36:35.854000Z"},{"_id":"66433eb34ecfda50de0ed5d0","body":"I was waiting for @akashrajkn to have time again, im not exactly a js wizard so if @shun2wang wants to have a look?","issue_id":1660519580461,"origin_id":1571947803,"user_origin_id":29062713,"create_time":1685621762,"update_time":1685621762,"id":1715682995858,"updated_at":"2024-05-14T10:36:35.857000Z","created_at":"2024-05-14T10:36:35.857000Z"},{"_id":"66433eb34ecfda50de0ed5d1","body":"Ah, I see... I will have a try if i could. thanks.","issue_id":1660519580461,"origin_id":1571974761,"user_origin_id":10348402,"create_time":1685623024,"update_time":1685623024,"id":1715682995860,"updated_at":"2024-05-14T10:36:35.860000Z","created_at":"2024-05-14T10:36:35.860000Z"},{"_id":"66433eb34ecfda50de0ed5d2","body":"Well, I can help out later, but Im going to be on vacation all of july and rather want to focus on the data-editing release before then. This would definitely be a nice feature to have.\r\n\r\nAnd if the only problem is unselecting the resizer when clicking out I think it will fall within my JS skillset :p","issue_id":1660519580461,"origin_id":1572010905,"user_origin_id":29062713,"create_time":1685624419,"update_time":1685624419,"id":1715682995863,"updated_at":"2024-05-14T10:36:35.862000Z","created_at":"2024-05-14T10:36:35.862000Z"},{"_id":"66433eb34ecfda50de0ed5d3","body":"Replaced by https:\/\/github.com\/jasp-stats\/jasp-desktop\/pull\/5285\r\n\r\nHi @akashrajkn I improved it in https:\/\/github.com\/jasp-stats\/jasp-desktop\/pull\/5285 if you want have a look you can review that, thanks:-)","issue_id":1660519580461,"origin_id":1760940961,"user_origin_id":10348402,"create_time":1697177094,"update_time":1697177833,"id":1715682995866,"updated_at":"2024-05-14T10:36:35.865000Z","created_at":"2024-05-14T10:36:35.865000Z"}]

### Description Allow adding and resizing images in the JASP editor. The resizing module is based on the code module available here: https://github.com/kensnyder/quill-image-resize-module (commit: kensnyder/quill-image-resize-module@60a43a2) #### Related Issues Fixes jasp-stats/INTERNAL-jasp#734...

akashrajkn