jasp-desktop
jasp-desktop copied to clipboard
jasp-stats
Replaced the `KeyNavigation.KeyUp` and `.KeyDown` with `tab` and `backTab`
Fixes https://github.com/jasp-stats/INTERNAL-jasp/issues/728 and fixes https://github.com/jasp-stats/INTERNAL-jasp/issues/1653
I tweaked the SpinBox just enough that it doesn't mess up with the navigation. It works much more predictable now. There are more to fix there, but I think we can just get rid of it at some point, and switch to the one that comes with Qt out of the box.
Also, in this, I have changed a few things to make the overall experience of the preferences consistent. I notice that we sometimes hide, or disable controls. I think disabling them is better than hiding them, and we do disable them for the most part, so I changed them all to be visible but enabled/disabled based on their values. You can see the changes in the PrefsData.
All the KeyNavigation,backtab and KeyNavigation.tab can be in fact removed. The QML engine is clever enough to find the next or previous control.
That's what I was hoping but I'm not sure if that's the case in different platforms. I still cannot do a lot of the keyboard navigation on my Mac, and if you remember we discussed this when I showed it to you. I don't know what's the case, but it's not working everywhere.
That's what I was hoping but I'm not sure if that's the case in different platforms. I still cannot do a lot of the keyboard navigation on my Mac, and if you remember we discussed this when I showed it to you. I don't know what's the case, but it's not working everywhere.
I will try it tomorrow on my PC-Windows at the UvA. I have also removed in another PR the period in 'Help us translate or improve JASP in your language.' You have now conflicts, but you just has to remove the files from your PR.