James M Snell

Results 646 comments of James M Snell

Had marked this ready but then remember I still had a few outstanding todos... specifically around thread-safety.... so back into draft it goes :-)

Yep, the way this is set up the exact flush option can be specified as an option, making it possible for us to evaluate the different options. Please definitely do...

@fhanau : > ...One style concern I have is that this requires external code to specify Z_SYNC_FLUSH when using the gzip implementation That was intentional to give us some flexibility...

@kentonv ... what is your recommendation on the best way to handle this with `evalLast()`? Specifically, since calls to `pump()` cannot overlap we need to introduce a small amount of...

Just fyi @flakey5 and I are both on vacation this week. I've mentioned to him that this conversation has come back around. His original PR vendoring it in is still...

I would definitely like to see the conversation around this progress but I'm not sure the proposal is adequate here. In some cases when *sending* trailers we do not actually...

@JakeChampion: > const incomingTrailers = await request.trailers(); I assume that awaiting this would force the entire body payload to be cached in memory?

Keep in mind that these are reversed on client and server sides. On the client side, a `trailers` callback would need to be provided in the `RequestInit`, while on the...

I've started to outline a proposal that covers both trailer support and early hints support here: https://docs.google.com/document/d/1P4MskkFd3HHFPGDr01O3wdFXukmX9i0jAb5uh9v9x8Q/edit ... comments welcome in the doc

Just keeping the conversation going. Based on feedback on the doc I [referenced above](https://docs.google.com/document/d/1P4MskkFd3HHFPGDr01O3wdFXukmX9i0jAb5uh9v9x8Q/edit), I've iterated a bit more on an approach for trailers that should be workable. Specifically, to...