James M Snell

Results 600 comments of James M Snell

@fhanau ... I wonder if it would be worthwhile adding a warning when `br` is specified without the flag / or in production. I know that warnings often go unnoticed...

+1 to this... But... Can we look at a friendly mode for displaying these that's less cplusplusy? For instance, we could just collapse this into a `JSON.stringify` item

I know it's been a while, but, can you provide a test case I can use to reproduce

This will likely need to come up on the tsc-agenda. /cc @nodejs/tsc

Or move those to a separate repo entirely. We do have dev-policy available for use. The deprecation policy document really ought to live there.

/cc @mikea ... this may have some interesting intersection with some of your other in-progress smart ptr proposals

Yep, currently in the workerd codebase we end up copying `Headers` for every iterator just in case they are modified. There's even a TODO comment in there indicating that a...

Briefly discussed with @mikea ... I definitely think this can be worked into the `kj::Rc` and `kj::Arc` proposals ... I do think we need to consider whether the write modifies...

```cpp kj::Rc foo = kj::refcounted(); kj::Rc ref = foo.addRef(); // Send ref off to something else... kj::Rc mutFoo = foo.makeWritable(); // Tho it does feel a bit weird for kj::Rc...

ok, I think this approach works. I'll work up a PR based on the `kj::Rc`/`kj::Arc` stuff.