James M Snell
James M Snell
PR #45032 replaces commit 9156797 in this PR. PR #45033 replaces commit 4fa7e02 in this PR. PR #45045 replaces commit 9c48c17 in this PR. Separated out to help continue reducing...
@tniessen ... smaller now :-)
@nodejs/collaborators @nodejs/tsc ... while this PR is not completely done, the lack of any review / feedback from contributors whatsoever is rather disheartening. If core contributors aren't interested in getting...
> Is there some way to cut this into smaller pieces? Sure, but it would be helpful to get some insight into what kind of division would make it easiest....
The changes to `src/crypto` have been moved out to #45912 to allow for incremental/independent review.
I have pulled off more of the implementation bits into a separate PR here: https://github.com/nodejs/node/pull/47263 The plan is to keep peeling pieces off into separate smaller PRs as much as...
I'm +1 on this moving forward but this needs docs.
There are relevant failures in CI on this.
@ronag @mcollina ... would definitely appreciate you taking a look at this one.
Yep. Making nextTick awaitable just makes things even weirder.