Jason R. Coombs

Results 1062 comments of Jason R. Coombs

Thanks for the report. I'm afraid I don't have the CSS expertise to even know which answer is right, but I'm happy to assume keegan.st is right. Would you or...

Well, shoot. It seems that after allowing pkginfo 1.11, the type checks are failing. It seems that `pkginfo.Distribution.name` was `str` and now is `str | None`. Same for `.version`.

> Random thought: is there a reason this can't constrain `pkginfo ~= 1.11` in `pyproject.toml`? That would avoid the need for the run-time version check + some of the extra...

I don't understand why the coverage tests are failing. They weren't failing before. Maybe the upstream changes pushed the coverage marginally lower and now these changes push them even lower?...

Due to #1121, I'm unable to locally assess the coverage issues.

> Taking a step back: apologies if I'm missing anything, but is there a reason `twine` can't go to `pkginfo >= 1.11` and avoid the backwards compat complexity here? See...

> The profile page for @sigmavirus24 suggests that he is “Taking a break from F/0SS indefinitely” — As such, is there another maintainer who may be approached about moving this...

I see now I missed the opportunity to add a changelog entry for this change. I'll do that in a separate PR.

> I suggest we remove this eager-`cache_clear` convenience entirely, as it would require us to rewrite the proposed solution to a full descriptor or use a subclass of built-in `property`,...

> > I suggest we remove this eager-`cache_clear` convenience entirely, as it would require us to rewrite the proposed solution to a full descriptor or use a subclass of built-in...