Jason R. Coombs

Results 1062 comments of Jason R. Coombs

> No id prefer to enable setuptools to provide dynamic requires depending on whether its running on a sdist or on a vcs checkout > > But if that fails...

I don't have a strong opinion on it, so I defer to Anderson's opinion. Therefore, I'm closing this as unmerged. We can revisit if a compelling argument can be made...

Thanks for the report. The `FileNotFoundError`s are from the performance benchmarks (exercises) when they try to invoke git (to compare for a baseline). These tests have no benefit for released...

Sorry for the delay in review. I'm still catching up on issues from May, but the PR caught my eye. The `register_at_fork` seems like a suitable workaround. I worry it's...

If only Python had a feature like C# or Swift to conditionally bypass null properties. ``` is_editable = bool(distribution.origin.?dir_info.?editable) ``` Since it doesn't, this library needs to provide special functions...

The code in `exercises.py` is run by `pytest-perf`. `pytest-perf` requires a git repo because it compares the performance of the code under test against the main branch. Since you're running...

It is something of a benchmark. It's a comparative benchmark. And currently, the test can never fail. It's there mainly to emit the differences in performance during a PR or...

> Just FYI, openSUSE runs the tests with > > ``` > %pytest --ignore exercises.py > ``` > > That’s, I guess, one way how to overcome this, right? That's...

@megies I'd be interested in your opinion on this change (applied first to `importlib_metadata` to later be incorporated into CPython).