John Jannotti

Results 92 comments of John Jannotti

> I like removal some of the shell scripts but I was nice to have all these deps listed in one place with versions. I think it's probably better to...

I guess `go tool` will be the way to do this soon.

I tentatively agree with you about you thinking about `LogicSigMaxSize()`. There is no explicit constant for a maximum argument size, so an argument can indeed by the whole 16kb in...

I was thinking about another approach. How about we just keep the `allocbound` on Args at 1000? There's no particular reason to need very large args. And, in fact, it's...

> You made me realize that indeed we need to decide which is the max limit for a logicsig arg. Before we had a combined cap for Logic + Args...

I'm really confused by that comment I mentioned. It says: ``` // TxnTagMaxSize is the maximum size of a TxnTag message. This is equal to SignedTxnMaxSize() // which is size...

After further discussion, we're confident that we can make changes to the max size tests so it doesn't fail so easily, without issue. I'll make those changes in a separate...

Ok, we merged a looser check that should allow this to pass tests. We came to pretty much the same result (5M limit) by another path. If you merge and...

Here is the PR to the spec for the similar change for logicsig _cost_ pooling. It contains a lot of other stuff too, but please look for the logicsig bits...

There are two small linter errors that should be fixed. They just appeared because the linter run needed approval to run.