John Jannotti

``` def sign(self, private_key): """ Sign the transaction with a private key. Args: private_key (str): the private key of the signing account Returns: SignedTransaction: signed transaction with the signature """...

#531 is working on this. Rather than changing `Transaction`, it adds `SignedTxnWithAD` which is the name of the structure that contains the `Transaction`, signature, and `ApplyData` in the Go code.

No one is working on it, but it seems like a nice convenience. Go for it!

This looks like the right approach to me. I don't know much about the Java sdk tests, but I'll try to look later. For me, as long as you have...

Thank you! I'm willing to take the PR as is (once we figure out why the integration tests fail) because it's better than what we had. But I did not...

I do not think this is a good idea, since it makes it easy to bloat transaction sizes. This is already a vector to annoy the network. Thankfully nobody has...

I'm mostly convinced by this: >But you can already send a transaction group with 16 lsigs of 1kb each for a total of 16kb. If we are happy with this...

I'm broadly positive on this. You make a pretty good case for this particular hash function, but I wonder what you think of `sumhash512`. If I understand correctly, we used...

It doesn't look like we have any test vectors here. I would like to see them. See, for example, `TestSHA3_256` or `TestSHA512_156` which is even better because it explains where...

> > I've submitted this. I don't know what they'll say, because I don't know the state of standardization of mimc hashing. [Consensys/gnark-crypto#504](https://github.com/Consensys/gnark-crypto/issues/504) > > ... Simply modulo reducing any...