John Jannotti

About to make a new PR with some small changes.

I think this is subsumed by 4401

Batching would also have the benefits of a) applying to many different APIs and b) allow for easy accounting if API providers wanted: "You have 100,000 'credits', one credit is...

Since AssembledBlock is a subset of ValidatedBlock, ledgercore.ValidatedBlock is both. And there are many places that use `ledgercore.ValidatedBlock` directly, instead of an interface. Unfortunately, that means that things like GenerateBlock...

> I can modify GenerateBlock too if it turns out there are no tests that use the deltas Would it be too crazy to give the Deltas() as different name...

> Looking at it now I'm not sure it's essential to modify the return type of `BlockEvaluator.GenerateBlock()`. Hiding the `BlockEvaluator`, dropping the deltas, and returning an `agreement.AssembledBlock` is the job...

I did this in my PR because I didn't want to change them both.

If you want to fix the conflict so that we move the unit test, I'd be happy to approve.

The Unicode replacement character is 2 bytes. But the Unicode encoding has variable length characters. On Fri, Oct 27, 2023, 8:25 AM Joe Polny ***@***.***> wrote: > meaning some characters...

Is this technique usable when the argument types or not simple `int`, `str`, etc? Does `isinstance(x, Union[int,str])` work? Edit: It does. So I would prefer we avoid the change that...