John Jannotti

Results 113 comments of John Jannotti

I made this PR on yours to make these changes. Happy to discuss further. https://github.com/giuliop/go-algorand/pull/1

Could you add mimcVersion to `experiments` so we don't release it to mainnet by mistake if we bump LogicVersion before this is completely ready? `var experiments = []uint64{spOpcodesVersion, mimcVersion}` I...

The easiest way to do this is a bunch of new `global` fields, and that is what I think we should do. But, it is worth considering that some callers...

Thanks for the detailed explanation. I agree that there are no good solutions that would let a mimc hasher's `Write()` operate on arbitrary byte strings, so I'd argue that a...

> an interesting idea to have a separate interfaces where hash.Hash works as expected If you go this way, please be sure to break existing consumers of `NewMiMC` at compile...

I'd support that, I believe it is fairly trivial, since Go's big.Int [supports it](https://cs.opensource.google/go/go/+/refs/tags/go1.23.1:src/math/big/int.go;l=560). I'm not completely sure about the cost. Can the computational cost be expressed by multiplying the...

Separately, I would also support an `rsa_verify` though my impression is that RSA has more competing formats than `ecdsa` or `ed25519`. Anyway, if someone wants RSA, it might make just...

voteFirst == 0 doesn't _really_ make sense, since it's supposed to be a round in which the given key can vote. But 0 is not an actual round. (Even if...

So we want Lora (through the sdk) to be able to read such a transaction, but I'm not hearing enthusiasm for sending such transactions. (Of course, I'd argue for simplicity,...

Are you wanting to keep the state delta for the entire block, or the detailed deltas for individual transactions?