tests: remove checkSpender duplicate function

[algorandskiy]

trafficstars

Summary

While discussing https://github.com/algorand/go-algorand/pull/5757 we found there is a duplicate checkSpender in ledger/apply and data/transactions. This PR eliminates the former and moves appropriate test to the latter package.

Test Plan

Existing tests.

Notes

Similarly to #5965 Merge after https://github.com/algorand/go-algorand/pull/5757 due to conflicts

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 56.19%. Comparing base (ff2c966) to head (1bb096a).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #5966   +/-   ##
=======================================
  Coverage   56.18%   56.19%           
=======================================
  Files         482      482           
  Lines       67989    67989           
=======================================
+ Hits        38199    38204    +5     
+ Misses      27201    27197    -4     
+ Partials     2589     2588    -1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[jannotti]

I did this in my PR because I didn't want to change them both.

[algorandskiy]

but TestCheckSpender still in ledger/apply - mb move to data/transaction and it will match

[jannotti]

If you want to fix the conflict so that we move the unit test, I'd be happy to approve.

[algorandskiy]

Moved the test and rebased.