Janic Duplessis comments

Results 217 comments of


                                            Janic Duplessis

Illegal node ID set as an input for Animated.DiffClamp node

Yes this PR will fix this :)

Android FPS

Strange, I only have a nexus 9 to test on. What device were you using?

[web-browser] Support CSS colors

Updated docs! Curious about how you will handle automatic conversions like this. Seems like currently only native knows what should be a color (on iOS, I guess android could add...

[web-browser] Support CSS colors

Cool! Would be nice to support rgb/hsl formats too, this is mostly why i made this PR :)

Deliver error for App containing an App Clip

@fastlane-bot Not fixed yet, mr. bot

Add allowDeclareFields to flow babel plugin

This actually seems to cause some issues since it will now cause property that are defined to be initialized to undefined, which means that if it overrides a property from...

Add allowDeclareFields to flow babel plugin

This PR seems like a good solution, maybe @makovkastar can have a look.

Add allowDeclareFields to flow babel plugin

Going to close this as it is a breaking change and I don't have time to work on a better solution at the moment.

[babel-plugin] Don't add es6 transforms when `unstable_disableES6Transforms` is set

cc @cpojer @rickhanlonii @motiz88

[babel-plugin] Don't add es6 transforms when `unstable_disableES6Transforms` is set

@rickhanlonii Is is possible that some project has the unstable_disableES6Transforms flag set? Otherwise I'm pretty confident this keeps the same plugin order.