Janic Duplessis comments

Results 217 comments of


                                            Janic Duplessis

[babel-plugin] Don't add es6 transforms when `unstable_disableES6Transforms` is set

@motiz88 I agree, the PR was patched on top of an existing option but `unstable_transformProfile` seems like a good fit. One issue I see though is it would be nice...

[babel-plugin] Don't add es6 transforms when `unstable_disableES6Transforms` is set

We might also want to organize this code differently if we're going to support more js engine profiles as I feel the current structure might get pretty nasty quickly.

[babel-plugin] Don't add es6 transforms when `unstable_disableES6Transforms` is set

I don't have time to work on this currently, if anyone wants to take on the project. I would suggest discussing it more here with @motiz88 and myself (see https://github.com/facebook/metro/pull/515#issuecomment-605374891).

[babel-plugin] Don't add es6 transforms when `unstable_disableES6Transforms` is set

I know hermes supports a lot more modern syntax now, I'd be interested to know if facebook leverages those yet internally.

Encode ..'s in asset paths fixes #290

@cpojer I think I pointed @imownbey towards this solution. This does happen for files included inside watchFolders (but not projectRoot). The case mentioned in the previous comment illustrates this. I...

Encode ..'s in asset paths fixes #290

@cpojer What about using some unique identifier like the asset hash (or whatever is the key of the asset in metro) and use that to build httpServerLocation. Maybe something like...

Fix platform inline transform for babel esmodules commonjs transform output

Yea, the current implementation is brittle since it doesn't have any info about modules and just relies on variable names. Passing the dependency map seems like the proper solution. I'll...

Fix platform inline transform for babel esmodules commonjs transform output

@motiz88 Any change we can merge this as is to fix the issue? Sadly I don't think I will have time to implement a better solution. If we don't want...

Crash on app reload on Android in `reanimated::NativeProxy::~NativeProxy`

This happens on a Pixel 4 api 31 emulator

Split layout props in GenericTouchable instead of using containerStyle

@yfunk I was also doing something like this in my Touchable component. I've taken the code and revised it to make sure all styles are included. Let me know what...