Jan Høydahl

Results 293 comments of Jan Høydahl

There are already 11 contributors to https://github.com/vdurmont/semver4j. Have you tried contacting them? Perhspa if we submit a PR for https://github.com/vdurmont/semver4j/issues/48 and ping a few of the devs, we can help...

I'll not veto the code copy, if you clearly mark it and open, say, a blocker JIRA for 10.0 or something to replace it with something that is maintained...

Interesting solution to this problem. Another way to fix it would be for the CurrencyFieldType to register `ScheduledExecutorService` and do the reloading in a tread-safe manner in that thread. It...

> This seems like a much better solution than mine. I will try to implement it in this pull request. I'd look at creating a pool `ScheduledExecutorService.newMDCAwareSingleThreadExecutor(new SolrNamedThreadFactory("currencyProvider"))`, and in...

> FWIW I went down this path in #699 and was told Jetty 10 was coming. I'm happy w/ this change though. I know, I'll link it here #585 for...

> Some of this was already done by @haythemkh . I'm not sure it needs a dedicated JIRA issue (compared to an overall issue for the other things for separating...

@dsmiley I'm happy to defer this, not to conflict with @haythemkh 's work. Will revisit after merge of 584 if anything is left to do.

> * In our javadocs, stop **linking** out to solrj or solrj-zookeeper because they cannot be differentiated by the standard javadoc tool. This seems acceptable for 9.x, and in main...

Jira SOLR-15258 is closed, can this PR also be closed?