solr icon indicating copy to clipboard operation
solr copied to clipboard

Published 20 hours ago • verified publisher icon apache

SOLR-15787: Implement FileSystemConfigSetService

Open NazerkeBS opened this issue 4 years ago • 7 comments
trafficstars

https://issues.apache.org/jira/browse/SOLR-15787

Description

Please provide a short description of the changes you're making with this pull request.

Solution

Please provide a short description of the approach taken to implement your solution.

Tests

Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem.

Checklist

Please review the following and check all that apply:

  • [ ] I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • [ ] I have created a Jira issue and added the issue ID to my pull request title.
  • [ ] I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
  • [ ] I have developed this patch against the main branch.
  • [ ] I have run ./gradlew check.
  • [ ] I have added tests for my changes.
  • [ ] I have added documentation for the Reference Guide

NazerkeBS avatar May 25 '21 07:05 NazerkeBS

@dsmiley, maybe I should update ZkConfigSetService#checkConfigExists in this PR to check if the config dir is not empty and contains solrconfig.xml file ?

NazerkeBS avatar May 25 '21 07:05 NazerkeBS

maybe I should update ZkConfigSetService#checkConfigExists in this PR to check if the config dir is not empty and contains solrconfig.xml file ?

No; it is unrelated to this PR.

dsmiley avatar May 25 '21 12:05 dsmiley

Jira SOLR-15258 is closed, can this PR also be closed?

janhoy avatar Nov 09 '21 15:11 janhoy

SOLR-15258 is a refactoring that we might say can include this or maybe not; it doesn't matter I suppose. It's 9.0 only so there is more fluidity. I suppose a separate issue feels better.

dsmiley avatar Nov 09 '21 20:11 dsmiley

The answer made me no wiser :) To me it looked like this is committed elsewhere without being closed. But you're saying this PR should get another JIRA number and remains to be merged? I did not look closely.

janhoy avatar Nov 09 '21 21:11 janhoy

@janhoy this PR is not committed before. I think jira number is confusing here as SOLR-15258 is already closed. I will create a jira issue and link this PR with that. But still it remains to be merged.

NazerkeBS avatar Nov 10 '21 17:11 NazerkeBS

Thanks for the clarification :)

janhoy avatar Nov 11 '21 14:11 janhoy

@NazerkeBS I see you added stuff outside of FileSystemConfigSetService. Can you summarize those changes please? What is the intent behind them? I suspect they are unrelated to FileSystemConfigSetService and thus should be a separate PR (probably no JIRA).

@dsmiley please see the comments above

NazerkeBS avatar Nov 29 '22 21:11 NazerkeBS

Tip: Follow the Google Java Format configuration settings for your IDE. Furthermore, I suggest telling IntelliJ to automatically apply formatting on commit. This will reduce the amount of "tidy"-ing you do a lot!

dsmiley avatar Dec 01 '22 23:12 dsmiley