Jan Philip Göpfert

Attack Overview with Properties

4

The table at [foolbox.attacks](https://foolbox.readthedocs.io/en/stable/modules/attacks.html#module-foolbox.attacks) is currently the closest thing to an overview of all implemented attacks. It could be an ideal place to list major defining properties, such as whether...

Use and link to correct paths

1

Although, according to a statement towards the beginning of the tutorial, paths were supposed to relative to the repository's root's parent, most were actually relative to the repository's root. The...

This is minor, I know. `tokenize` simply iterates over `texts`, so in addition to `list`, `tuple` is fine. The intended type hint for this is `Sequence`. I am not sure...

`setup.py` should define actual dependencies

5

Currently, the packages specified in `requirements.txt` are copied into `setup.py`: ```python install_requires=load_text("requirements.txt").strip().split("\n"), ``` This is bad practice and can cause problems downstream. `requirements.txt` should be used to define a repeatable...

Tests require missing images

4

Several tests (for example, the one in `test_estimate_alpha.py`) fail because a required image is missing: ``` FAILED tests/test_estimate_alpha.py::test_alpha - FileNotFoundError: [Errno 2] No such file or directory: 'data/input_training_lowres/GT01.png' FAILED tests/test_laplacians.py::test_laplacians...

In [`demo.tex`](https://github.com/astoeckel/smart-thesis/blob/501608f34c19786b7d2009f1e5264449d48d1b05/demo.tex), [`\input{style}`](https://github.com/astoeckel/smart-thesis/blob/501608f34c19786b7d2009f1e5264449d48d1b05/demo.tex#L11) comes before [`\input{common-packages}`](https://github.com/astoeckel/smart-thesis/blob/501608f34c19786b7d2009f1e5264449d48d1b05/demo.tex#L15), which makes sense. However, [`hyperref`](https://github.com/astoeckel/smart-thesis/blob/501608f34c19786b7d2009f1e5264449d48d1b05/common-packages.tex#L46) needs to be loaded before we use [`\newsubfloat{figure}`](https://github.com/astoeckel/smart-thesis/blob/501608f34c19786b7d2009f1e5264449d48d1b05/style.tex#L233): https://tex.stackexchange.com/a/303156 What to do, what to do?

`firebase deploy` fails to delete task function with an underscore in its name

3

### [REQUIRED] Environment info **firebase-tools:** 13.11.4 **Platform:** Ubuntu 23.10 / fish ### [REQUIRED] Test case ```python from firebase_functions import tasks_fn @tasks_fn.on_task_dispatched() def dummy_function(request: tasks_fn.CallableRequest) -> str: return "Hello World" ```...