Jan Philip Göpfert

Results 10 comments of Jan Philip Göpfert

> Suggestions? - asdatabases - aiodb

Yes. `Update #1`: I have absolutely no idea what I'm doing with `sphinx`, so it will result in an extra script that will spit out a table to be manually...

If I am not mistaken, this does not only pertain to CW, correct? This should definitely be mentioned in the documentation, and it might even be worthwhile to include a...

3. List and explain implemented criteria, and show how they are used. `labels` are automagically interpreted as [`Misclassification`](https://github.com/bethgelab/foolbox/blob/ca8bc831005b516953af0616785762311f858b40/foolbox/criteria.py#L96), which hides the necessity and importance of criteria (see https://github.com/bethgelab/foolbox/issues/543#issuecomment-631861469) This would...

4. List related projects, such as [cleverhans](https://github.com/cleverhans-lab/cleverhans) and [torchattacks](https://pypi.org/project/torchattacks/).

5. What values are returned by attacks and what do they mean? This is mostly about the relationship between `raw` adversarials and `clipped` adversarials. Also, what does `is_adversarial` relate to?

@yitao416 Which “latest attack method” are you referring to? I agree that returning `adversarials` and `clipped_adversarials` can be confusing, especially seeing that the differences aren't documented, and one might assume...

> You are right that we should put this in the documentation. @jangop If you have the time and already an idea how to implement your suggested changes please feel...

Oh. Thanks. Would it be okay to have them downloaded automatically?

Yes... Maybe I'll have pytest issue a warning for people such as myself who miss that line in the readme.