CLIP icon indicating copy to clipboard operation
CLIP copied to clipboard

Accept `Sequence` instead of `List`

Open jangop opened this issue 2 years ago • 0 comments

This is minor, I know. tokenize simply iterates over texts, so in addition to list, tuple is fine. The intended type hint for this is Sequence.

I am not sure which version of Python this project targets, but judging from the other type hints in this file, I am going to assume <3.9. Otherwise, I would suggest importing Sequence from collections.abc instead of typing.

jangop avatar Sep 14 '22 14:09 jangop