jamshale

Results 217 comments of jamshale

> All tests should be fixed now. I updated/synced the version of Black as three different versions were specified between `pyproject.toml`, `.pre-commit-config.yaml` and `blackformat.yml` and ran the formatter on the...

For: `On aca-py startup, verify that the configured --wallet-type matches the actual database. If the wallet is askar and aca-py is started with --wallet-type askar-anoncreds, aca-py should shut down with...

This :point_up: makes sense. But, I am a bit unsure about what to do with and `indy` wallet and config. I was thinking if the record is `None` and the...

I agree that it's hard to write unit tests that aren't brittle and over mocked. I still think they are valuable for smaller blocks of code to ensure the intended...

I haven't been able to re-produce this. I tried by creating and registering a did with `endorser` role and another with `user` or none role. When using the endorser I...

Going to close. If this gets reported again or the steps to reproduce are updated we can open it back up.

> hmmm, getting a pipeline failure; i dont know acapy CI enough to know if this normal... Trying to re-run. Integration tests have been getting sporadic fails when there's multiple...

Not sure why this PR is getting so many random integration test fails. Not the same as the ones as I fixed recently. Might try an look at these other...

> @jamshale Yeah the tests seem so finicky. They seem to get worse sometimes and are better sometimes. The last fail was the one I thought I had fixed. Hadn't...

Is this an issue still? It doesn't seem like it. Most likely fixed in a patch release. I'm going to close as stale. Feel free to comment and get it...