jamshale
jamshale
I may be able to use the same code coverage artifact to avoid needing to run the tests on merge to main. I will look at doing that. For the...
@WadeBarnes So, I tried to use the previous test coverage artifact but have been having a hard time locating it from this workflow. It's a lot different than the other...
Ok. Hopefully a simple fix. I was a bit unsure what we were doing with extras in general. But it makes sense it wouldn't be required.
So, I agree that maybe we shouldn't require anoncreds to be installed. But, I don't think this is an issue with the anoncreds upgrade endpoint in particular. I've checked out...
> So should we move the library from being an extra to being a strict dependency? Or maybe I misunderstood what you mean I think that's a good idea. I...
I'm not certain what to do about this. anoncreds was always installed if the `askar` extra was installed. See https://github.com/hyperledger/aries-cloudagent-python/blob/main/pyproject.toml#L84 It will fail if you install extras without specifying askar...
Closing. If this comes up again we can re-open.
Just install anoncreds. It's a required extra. It should be included in the lastest version by default.
@ianco I rebased to fix a merge conflict and need re-approval, please.
I think this is ok for now. Thanks for figuring it out. Maybe we can just add some notes where the profile is added as a parameter that this was...