jamshale
jamshale
I'm back and going to address the documentation in an additional ticket https://github.com/hyperledger/aries-cloudagent-python/issues/2875
> Code looks good overall, I flagged a couple items that need to be looked at. Also wondering if it would make sense (and there is a way) to test...
> > I don't think the upgrade should take very long for any agents or subwallets as the DB changes are just removing and replacing records. > > ... as...
> > As I understand it, the plan is that the controller is responsible for scaling down, then start back up and calling this endpoint during controller initialization before proceeding....
@ianco I'm going to create a separate document for the design of this with some diagrams so it's clear and can be referenced in the future. It will be separate...
@ianco @swcurran I'm removing the in memory singleton part of this, and instead using the wallet(DB) value in the middleware. I hadn't considered the scaled up, multi instance use case...
I'm going to close this PR and open a new PR to clean it up.
> I'm not as close to the AnonCreds changes of late so it might be valuable to get input from others still but I found this document to be quite...
I'm a bit unsure where this is at? I'll approve it though if you think it's good @amanji ?
This fix was merged so I believe this issue can be closed.