James Ward

Results 215 comments of James Ward
trafficstars

@SudharakaP Correct, Cloud Run Button doesn't support custom buildpacks defined by `app.json` yet. @ahmetb The name is unrelated. There is a custom buildpack defined that is needed to build the...

@jkutner Thanks! There is an existing bug about invalid container image names based on `app.json`: https://github.com/GoogleCloudPlatform/cloud-run-button/issues/57

Oh, and the error about the `page` param is something we are fixing right now: #114

Thanks @jkutner! So, in the CNB world, what is the right way to handle custom specified buildpacks?

Thanks @jkutner, doesn't the `--buildpack` option just override the detect phase and need to be a buildpack location in the builder image or a tar/tgz? In which case we won't...

I think our current plan is to add ignored fields as they arise. I'll create a PR for that.

@SpEcHiDe Thanks for reporting! Here is the PR: https://github.com/GoogleCloudPlatform/cloud-run-button/pull/193

Awesome! So great to get this finally in! This looks good but I didn't look into why the tests are failing.

Sounds great to me but we do need to push to get a Cloud Run bug fixed where most buildpack built images do not currently work (Node & Python are...

It’s actually a bug in Cloud Run, because the containers work fine in docket.