James Ward
James Ward
Which standard would you like to use as a basis for your position?
Nice! I like it.
What about setting up `github.cloud.run` for this? Could just redirect to `deploy.cloud.run` with the right `git_repo`.
Good question. I have some repos that use `cloudbuild.yaml` but I think you are right that those could easily be converted to buildpacks or Dockerfile. And since we can actually...
As #85 points out, one use case for this is builds that use Jib. It doesn't make sense with those to use docker or buildpacks so having a `cloudbuild.yaml` that...
As far as implementation... Right now we check for a `Dockerfile` and if it exists we run docker, otherwise we try the buildpacks. We should first check for a `cloudbuild.yaml`...
Yeah, our `app.json` parsing is strict so likely we just need more ignore flags. I think this is the file that is failing: https://github.com/SudharakaP/jhipster-registry/blob/add-gcp-cloud-run-deploy-button/app.json I can investigate.
Officially, `required` is a boolean in `app.json` https://devcenter.heroku.com/articles/app-json-schema#env Our parsing should be able to handle that. For the `buildpacks` param, I think it'd be ok to ignore it for now,...
I'm guessing is actually not going to work because it is using a non-default buildpack. Maybe @jkutner can let us know if the `https://github.com/jhipster/jhipster-registry-buildpack` buildpack will work with the CNB...
This is because you need the custom buildpack to build this project.