cloud-run-button icon indicating copy to clipboard operation
cloud-run-button copied to clipboard

Published 20 hours ago • verified publisher icon GoogleCloudPlatform

Add support for "buildpacks" field in app.json

Open ahmetb opened this issue 6 years ago • 5 comments
trafficstars

ahmetb avatar May 14 '19 21:05 ahmetb

@jamesward I feel like we should just assume --builder=heroku/buildpacks, and then have an optional array for --buildpack, so we call the CLI like:

pack build --builder=heroku/buildpacks [--buildpack=foo --buildpack=bar ...]

wdyt?

ahmetb avatar May 28 '19 23:05 ahmetb

Sounds great to me but we do need to push to get a Cloud Run bug fixed where most buildpack built images do not currently work (Node & Python are currently broken).

jamesward avatar May 29 '19 10:05 jamesward

Yes learned it the hard way yesterday. The whole project does not seem stable or ready for prime-time. I won’t be touching this anytime soon.

ahmetb avatar May 29 '19 14:05 ahmetb

It’s actually a bug in Cloud Run, because the containers work fine in docket.

jamesward avatar May 29 '19 14:05 jamesward

There is a way to specify specific buildpacks via a project.toml file in the root: https://github.com/buildpacks/pack/pull/421

jamesward avatar Jun 26 '20 12:06 jamesward