James Ward

Results 233 comments of James Ward
trafficstars

Most of these samples were originally created to show Cloud Run Button + Buildpacks using Heroku's buildpacks. But now that we've got them all working with our buildpacks you are...

Yikes. Yeah, given the lack of any standard conventions it seems that the error route is the only viable one.

Does it make a difference if you remove the `project.toml` file?

Can you run the `pack build` again but with a `-v` flag so we can see the detection results?

So https://github.com/GoogleCloudPlatform/buildpacks/blob/10f6e4f050380c3a16bfdebcd601876b97373fde/cmd/python/runtime/main.go#L50 Is matching but this seems like maybe a bug since just having a `.py` file somewhere in the source tree shouldn't trigger it being a python project. Does...

I'd say bug. But I'd also say that you shouldn't run buildpacks on a node project that already has a `node_modules` dir since the buildpack is supposed to do the...

Docs say exclude from build but I'm not sure if that also means detect: https://buildpacks.io/docs/reference/config/project-descriptor/#build-_table-optional_

Let's keep it open. To summarize, a .py file anywhere in the source tree shouldn't make the python buildpack pass detection.

One option is to apply the `.gitignore` as default build excludes. This would also help with congruence between local run & CI run. Not sure if this should just be...