James Martin

Results 39 comments of James Martin

Thanks for opening this issue. ✨ Apologies that the cached asset file is not working as expected. When using this in production I always use paths containing non-fingerprinted, "static", assets....

I'm throwing this open to anybody that wants to help. I probably won't be able to get to this quickly and it doesn't seem critical, so PRs are welcome. 🙇

> Feels a bit weird to me to have to define in respective view files if I use sprockets or webpacker, and have to change all my svg view code...

@felipefava thanks for opening this issue. ✨ I'm not against the idea of supporting a Webpacker convention if it makes the experience better for users of this library. 👍 If...

> I mean, if in some part of the code I use `image_pack_tag 'my_folder/my_image.png'`, I would also expect to use `inline_svg_pack_tag 'my_folder/my_svg.svg'` instead of `inline_svg_pack_tag 'media/images/my_folder/my_svg.svg`. Makes sense to me....

@mjankowski thanks for opening this PR! ✨ > I assumed (incorrectly) that inline_svg would "just work" within that setup, but I think it needs to be explicitly configured to use...

Thanks for the feedback, I'll update the test App so we have a Rails 7 with and without Sprockets. Regarding this gem's compatibility with Rails 7, it feels like we...

👋 thanks for opening this issue, @ryanb. ✨ > If I have a list of a hundred items which all reference the same `inline_svg_tag` image, the content is duplicated for...

@ryanb thanks for the examples, that does seem like a useful feature, especially if there is no cross-domain problem in your use-case. Based on your second example, which is no...

@ryanb thanks for the extra detail, I understand what you're getting at now. > I understand if this is outside the scope of `inline_svg` since it involves some asset pipeline...