James Martin

Results 39 comments of James Martin

Our tests were failing on CI because our Rails `config.time_zone` was configured to one thing, but the CI machine was configured to something different. Calling `Time.zone.now` returned the Rails configured...

@skedwards88 just to clarify, are you asking for review of the [cross-referenced PR](https://github.com/github/docs/issues/22270#issuecomment-1505490294)? Or something else?

Thanks for clarifying, @skedwards. I think #24965 only covers [the additional discovery that PKCE is not supported](#issuecomment-1327726265). The fact that we block `OPTIONS` requests, and therefore CORS preflight requests don't...

> Before I make any documentation change, how can I request the feature formally? We're tracking this feature internally and the discussion here has already been helpful to bring fresh...

> - [x] I wrote this. Do you want this? @jakewilkins 💯 Thanks for opening this PR. I *love* the direction you've chosen for the API here. I wonder if...

Apologies for the lack of updates recently. I'll be moving forward with support for Shakapacker 8, roughly following [the strategy outlined by @tagliala](https://github.com/jamesmartin/inline_svg/pull/158#issuecomment-2241158893). In addition, I'll be bumping this gem...

Thanks for opening this issue and providing helpful background information about the request to encode SVG documents in a suitable format for CSS data-urls. I think you're correct about this...

Thanks for opening this PR. New branch created in the `inline_svg_test_app` repo for `rails7-shakapacker` so you can get the integration tests running.

Thanks again, @tagliala! ✨

Thanks for the suggestion. Definitely not against this idea in principle but would only be possible if somebody from the community were prepared to work on this. Obviously this kind...