inline_svg icon indicating copy to clipboard operation
inline_svg copied to clipboard

Published 20 hours ago • verified publisher icon jamesmartin

Version 2.0

Open jamesmartin opened this issue 6 years ago • 3 comments

A laundry list of things we'd like to do for version 2.0:

  • [ ] Drop support for older Rails versions (ideally only support Rails 6 and Rails 5)
    • We'll keep a v1 branch around and patched for security vulnerabilities while people migrate to v2
  • [ ] Remove the inline_svg helper in favor of the new specific helpers introduced in #103
  • [ ] ...

jamesmartin avatar Nov 13 '19 04:11 jamesmartin

Would love to keep inline_svg as the default method, and instead be able to configure if it should point to sprockets or webpacker. Feels a bit weird to me to have to define in respective view files if I use sprockets or webpacker, and have to change all my svg view code if I change from one to the other!

DanielJackson-Oslo avatar Oct 05 '21 09:10 DanielJackson-Oslo

Feels a bit weird to me to have to define in respective view files if I use sprockets or webpacker, and have to change all my svg view code if I change from one to the other!

Agreed. 👍

jamesmartin avatar Oct 07 '21 04:10 jamesmartin

Feels a bit weird to me to have to define in respective view files if I use sprockets or webpacker, and have to change all my svg view code if I change from one to the other!

Agreed. 👍

Does that mean we can get rid of the depreciation warning for using inline_svg? I can make a PR for that, if you'd like?

DanielJackson-Oslo avatar Oct 29 '21 12:10 DanielJackson-Oslo