Jan Macku comments

Results 69 comments of


                                            Jan Macku

Shown alerts should include a possible solution (if available)

Possible solution would be implementation of: - https://github.com/csutils/csdiff/issues/140

Utilize Job summaries in DEBUG mode 🧰

Fixed by: - #110 You can now upload the SARIF file as artifact using `actions/upload-artifact` GitHub Action: ```yaml - if: ${{ always() }} name: Upload artifact with ShellCheck defects in...

Investigate how we are dealing with renaming of files :card_file_box:

GitHub is doing some pre/post-processing of SARIF files (but there is no documentation). It includes its own fingerprints if no fingerprints are available. This is why differential-shellcheck sometimes reports some...

[ANNOUNCEMENT] - Differential ShellCheck future architecture changes :building_construction:

Hmm, I was thinking that `cswrap action` could generate more output types, not only `SARIF`. But in general it's possible to merge them together.

Using env.runner_temp instead of home directory to write json file

Maybe https://github.com/stefanbuck/github-issue-parser/pull/71/files#diff-870c1528a9710168a5ac887a90f4232e243a6193f2be70cb7c22946238760f67R99. It seems that it also confused the semantic-release bot - https://github.com/stefanbuck/github-issue-parser/pull/71#issuecomment-2138045496

fix(checkboxes): correctly parse checkboxes when the template is wrong or missing

@joshjohanning, @gr2m, Could you please have a look? Thank you.

fix(checkboxes): correctly parse checkboxes when the template is wrong or missing

Thank you @gr2m 👍

Add support for other formats than SARIF

Differential ShellCheck internally uses [`csdiff` and `csgrep`](https://github.com/csutils/csdiff), tools written by @kdudka and @lzaoral. `csdiff` handles the differential part of scanning, and `csgrep` is used to produce various formats (e.g., JSON,...

Accept command line arguments instead of environment variables

Thank you for writing this down. I'll have a look and implement argument parsing.

Accept command line arguments instead of environment variables

The `INPUT_INCLUDE_PATH` was introduced for specific use cases when a shell script is not detectable in any other way, so users point to the files manually. The logic you are...