Jan Macku

Still an issue.

Still an issue.

> So what I want mandatory is that one can see the severity ('error' 'warning' 'info' 'style') of each reported ShellCheck issue. > > E.g. we may initially limit reported...

Differential ShellCheck now allows to define minimal defect severity to be reported - https://github.com/redhat-plumbers-in-action/differential-shellcheck#severity

> Hi @jamacku , Thank you for doing it. I've tried this configuration, and I've got the message: Warning: Unexpected input(s) 'severity', valid inputs are ['entryPoint', 'args', 'base', 'head', 'ignored-codes',...

> Why not full scan? Doing a full scan on most repositories usually produce a lot of noise ("old defects"). Therefore, it's challenging for projects with a lot of shell...

It should also catch changes in `cht.sh.txt` [since shebang is defined](https://github.com/redhat-plumbers-in-action/differential-shellcheck#features). ShellCheck doesn't necessarily make your code base more secure, but it can help you to review PRs and potentially...

Oh, never mind, I just noticed that you already have a shellcheck that uses SARIF. And since you don't have any shellcheck warnings in your current code base, you probably...

Hmm, for some reason `differential-shellcheck` was not able to [upload SARIF to GitHub](https://github.com/osbuild/osbuild/actions/runs/3271767552/jobs/5381947979#step:4:20). I have never encountered this issue. It may be caused by some permission restrictions if you have...

> Hmm, for some reason `differential-shellcheck` was not able to [upload SARIF to GitHub](https://github.com/osbuild/osbuild/actions/runs/3271767552/jobs/5381947979#step:4:20). I have never encountered this issue. It may be caused by some permission restrictions if you...