Jan Macku
Jan Macku
I would love to see native SARIF support in ShellCheck, but I also know how [complex](https://docs.oasis-open.org/sarif/sarif/v2.1.0/sarif-v2.1.0.html) the format specification is. Maybe something to note is that there are at least...
> This is very cool thanks! I'm glad you like it! :+1: > Is there a way we can keep in sync the options from the normal shellcheck run and...
Differential ShellCheck now allows to define minimal defect severity to be reported - https://github.com/redhat-plumbers-in-action/differential-shellcheck#severity The default value is set to `style`.
@89luca89, missing comments are weird, but I think there is nothing I can do about it. I already saw it (but rarely). For context, `differential-shellcheck` will generate a report in...
I have rebased PR on top of the current main. Let's see if it makes any difference.
I'm not sure what caused the missing comments. GitHub's processing of SARIF is black-box. :facepalm: It recently happened on https://github.com/cea-hpc/modules/pull/471/files#diff-41fa2dac924cdeb2ce53a18b52ebe93233d4ef3b34440ddb03ce176bb2aa3360 as well.
@89luca89 I would guess that GitHub doesn't check if there is a comment for a given defect (that's why there were no comments created after rebase), but when you add...
> Cool seems ok Last question, is there something that can indicate the user that they need to check the "Files Changed" page for a full list of warnings? That...
> Understandable, anyway seems to work fine, we'll see if there are any problems in the future smile Thanks a lot for the contribution! Feel free to ping me if...
Still an issue.