Investigate how we are dealing with renaming of files :card_file_box:

[jamacku]

Type of issue

Bug Report

Description

There might be issue with differential-shellcheck when shell script is renamed (and contain some changes)

Describe the solution you'd like

No response

[mpoberezhniy]

I renamed one of directories in my repository and differential shellcheck displayed all the defects from that directory in the log, but GitHub did not show any of those.

This is a bit unexpected because no warnings were shown but the action was red.

[jamacku]

GitHub is doing some pre/post-processing of SARIF files (but there is no documentation). It includes its own fingerprints if no fingerprints are available. This is why differential-shellcheck sometimes reports some defects, but the GitHub SARIF upload is green.

The latest version should improve this situation, as it has the latest version of csdiff, which now also generates fingerprints.

Renaming directories/files might still be an issue. But there are differential actions for Python that is able deal with renames and moves.

• https://github.com/fedora-copr/vcs-diff-lint/blob/main/vcs-diff-lint#L173

This is definitely something that I would like to get fixed. It is long overdue.