Jake Bailey
Jake Bailey
Given https://github.com/groestlcoin/bip38grs, you are the primary author of this package; why not ship these types with your package?
I deleted ts4.8 in #68908, you'll have to update the PR again (sorry!)
Do you have any links to docs that would show that this PR is correct?
Why is the module setting a problem? The tests pass; am I missing something? `export as namespace` should work in `node16` too.
I am definitely not experienced enough to know what to do about UMD modules. We could flip back to module=commonjs, but it sure feels gross. But I think I'd need...
I don't understand the change; you're removing the React import, which is most definitely needed to be able to use `React.Component`. The tsconfig change doesn't do anything for the tests...
Your screenshot in the original issue isn't from ESLint (which you should not be running on `node_modules` anyway). The screenshot is a TypeScript error message; it sounds more like you...
I'm going to close/reopen this just because I'm sure the CI results are stale. My main concern is that this is not updating the types for the other versions; is...
Yeah; v16 and v18s types are still supported and should be updated if possible.
Thanks for updating the PR; are there any remaining concerns? This PR had a couple previous thumbs up, and I don't have any particular notes about this besides that it...