Jake Bailey
Jake Bailey
That's a lot of formatting changes; I'm not sure how we can validate this when there's so much noise and without any documentation.
Why make these required if they have defaults?
That change certainly seems fine, though potentially a bit annoying to anyone who's dynamically setting these as you are going to need a literal `true` to get it to match....
Please use https://github.com/DefinitelyTyped/DefinitelyTyped/discussions so the infra can ping the right people.
The version needs to be v2 for this to be right
Hm, I think this lint is wrong on our end: ``` /home/runner/work/DefinitelyTyped/DefinitelyTyped/types/qz-tray/index.d.ts Error: 544:1 error Instead of `export =`-ing a namespace, use the body of the namespace as the module...
No, sorry, I think I'm wrong and you can actually just write `export as namespace qz` without having put everything into a namespace. Sorry for the churn.
Er, that last commit does not seem right. This package does not have a named export `qz`. I think you can just revert the last two commits and add `export...
I'll approve it, but you really should just have the types in a package you own. All you have to do is copy the index.d.ts.
Why are you submitting types for an internal project on DT? This is not the right place for that sort of thing.