DefinitelyTyped [node] Add "signal" to NodeJS's AddEventListenerOptions

Please fill in this template.

[x] Use a meaningful title for the pull request. Include the name of the package modified.
[x] Test the change in your own code. (Compile and run.)
[ ] Add or edit tests to reflect the change.
[x] Follow the advice from the readme.
[x] Avoid common mistakes.
[x] Run pnpm test <package to test>.

Select one of these and delete the others:

If adding a new definition:

[ ] The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
[ ] If this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
[ ] Create it with dts-gen --dt, not by basing it on an existing project.
[ ] Represents shape of module/library correctly
[ ] tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

If changing an existing definition:

[x] Provide a URL to documentation or source code which provides context for the suggested changes: https://nodejs.org/api/events.html#eventtargetaddeventlistenertype-listener-options
[x] If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the package.json.

If removing a declaration:

[ ] If a package was never on Definitely Typed, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
[ ] Delete the package's directory.
[ ] Add it to notNeededPackages.json.

Feb 14 '24 08:02 matthieusieben

@matthieusieben Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

node — on npm, on unpkg
- owner-approval: @Semigradsky, @peterblazejewicz

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

✅ No merge conflicts
✅ Continuous integration tests have passed
✅ Only a DT maintainer can approve changes without tests

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

Inactive

This PR has been inactive for 17 days — please merge or say something if there's a problem, otherwise it will be closed!

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 68625,
  "author": "matthieusieben",
  "headCommitOid": "5b1aa80410668d0724850f8d6d5e21ab5348ecc8",
  "mergeBaseOid": "96f19adef728f6aa5b1a958b7e0d127e11a0a7b9",
  "lastPushDate": "2024-02-14T08:52:30.000Z",
  "lastActivityDate": "2024-03-30T05:00:13.000Z",
  "mergeOfferDate": "2024-03-12T20:55:01.000Z",
  "mergeRequestDate": "2024-03-30T05:00:13.000Z",
  "mergeRequestUser": "Semigradsky",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "node",
      "kind": "edit",
      "files": [
        {
          "path": "types/node/dom-events.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v16/dom-events.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v18/dom-events.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "Microsoft",
        "jkomyno",
        "alvis",
        "r3nya",
        "btoueg",
        "smac89",
        "touffy",
        "DeividasBakanas",
        "eyqs",
        "Hannes-Magnusson-CK",
        "hoo29",
        "kjin",
        "ajafff",
        "islishude",
        "mwiktorczyk",
        "mohsen1",
        "galkin",
        "parambirs",
        "eps1lon",
        "ThomasdenH",
        "WilcoBakker",
        "wwwy3y3",
        "samuela",
        "kuehlein",
        "bhongy",
        "chyzwar",
        "trivikr",
        "yoursunny",
        "qwelias",
        "ExE-Boss",
        "peterblazejewicz",
        "addaleax",
        "victorperin",
        "ZYSzys",
        "NodeJS",
        "LinusU",
        "wafuwafu13",
        "mcollina",
        "Semigradsky"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "Semigradsky",
      "date": "2024-03-30T04:59:55.000Z",
      "isMaintainer": false
    },
    {
      "type": "approved",
      "reviewer": "peterblazejewicz",
      "date": "2024-03-12T20:42:22.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 1943321444,
  "ciResult": "pass"
}

Feb 14 '24 08:02 typescript-bot

🔔 @Microsoft @jkomyno @alvis @r3nya @btoueg @smac89 @touffy @DeividasBakanas @eyqs @Hannes-Magnusson-CK @hoo29 @kjin @ajafff @islishude @mwiktorczyk @mohsen1 @galkin @parambirs @eps1lon @ThomasdenH @WilcoBakker @wwwy3y3 @samuela @kuehlein @bhongy @chyzwar @trivikr @yoursunny @qwelias @ExE-Boss @peterblazejewicz @addaleax @victorperin @ZYSzys @NodeJS @LinusU @wafuwafu13 @mcollina @Semigradsky — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

Feb 14 '24 08:02 typescript-bot

@matthieusieben One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!

Feb 15 '24 15:02 typescript-bot

@Semigradsky done :-)

Feb 19 '24 09:02 matthieusieben

@Semigradsky Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

Feb 19 '24 10:02 typescript-bot

:hourglass_flowing_sand: Hi @matthieusieben,

It's been a few days since this PR was approved by peterblazejewicz, Semigradsky and we're waiting for a DT maintainer to give a review.

If you would like to short-circuit this wait, you can edit some of the test files in the package which verify how the .d.ts files work. This would allow the PR to be merged by you or the DT module owners after a re-review.

Feb 19 '24 19:02 typescript-bot

Re-ping @matthieusieben / @Microsoft, @jkomyno, @alvis, @r3nya, @btoueg, @smac89, @touffy, @DeividasBakanas, @eyqs, @Hannes-Magnusson-CK, @hoo29, @kjin, @ajafff, @islishude, @mwiktorczyk, @mohsen1, @n-e, @galkin, @parambirs, @eps1lon, @ThomasdenH, @WilcoBakker, @wwwy3y3, @samuela, @kuehlein, @bhongy, @chyzwar, @trivikr, @yoursunny, @qwelias, @ExE-Boss, @addaleax, @victorperin, @ZYSzys, @NodeJS, @LinusU, @wafuwafu13, @mcollina:

This PR has been ready to merge for over a week, and I haven't seen any requests to merge it. I will close it on Mar 20th (in three weeks) if this doesn't happen.

(If there's no reason to avoid merging it, please do so. Otherwise, if it shouldn't be merged or if it needs more time, please close it or turn it into a draft.)

Mar 01 '24 01:03 typescript-bot

I deleted ts4.8 in #68908, you'll have to update the PR again (sorry!)

Mar 11 '24 22:03 jakebailey

@matthieusieben Unfortunately, this pull request currently has a merge conflict 😥. Please update your PR branch to be up-to-date with respect to master. Have a nice day!

Mar 11 '24 22:03 typescript-bot

It has been more than two weeks and this PR still has no reviews.

I'll bump it to the DT maintainer queue. Thank you for your patience, @matthieusieben.

(Ping @Microsoft, @jkomyno, @alvis, @r3nya, @btoueg, @smac89, @touffy, @DeividasBakanas, @eyqs, @Hannes-Magnusson-CK, @hoo29, @kjin, @ajafff, @islishude, @mwiktorczyk, @mohsen1, @galkin, @parambirs, @eps1lon, @ThomasdenH, @WilcoBakker, @wwwy3y3, @samuela, @kuehlein, @bhongy, @chyzwar, @trivikr, @yoursunny, @qwelias, @ExE-Boss, @peterblazejewicz, @addaleax, @victorperin, @ZYSzys, @NodeJS, @LinusU, @wafuwafu13, @mcollina, @Semigradsky.)

Mar 12 '24 20:03 typescript-bot

@matthieusieben I've taken the liberty to refresh the PR (rebasing against current master), as this PR took already long time to get here. Thanks!

Mar 12 '24 20:03 peterblazejewicz

@Semigradsky Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

Mar 12 '24 20:03 typescript-bot

Re-ping @matthieusieben / @Microsoft, @jkomyno, @alvis, @r3nya, @btoueg, @smac89, @touffy, @DeividasBakanas, @eyqs, @Hannes-Magnusson-CK, @hoo29, @kjin, @ajafff, @islishude, @mwiktorczyk, @mohsen1, @galkin, @parambirs, @eps1lon, @ThomasdenH, @WilcoBakker, @wwwy3y3, @samuela, @kuehlein, @bhongy, @chyzwar, @trivikr, @yoursunny, @qwelias, @ExE-Boss, @addaleax, @victorperin, @ZYSzys, @NodeJS, @LinusU, @wafuwafu13, @mcollina:

This PR has been ready to merge for over a week, and I haven't seen any requests to merge it. I will close it on Apr 11th (in three weeks) if this doesn't happen.

(If there's no reason to avoid merging it, please do so. Otherwise, if it shouldn't be merged or if it needs more time, please close it or turn it into a draft.)

Mar 23 '24 01:03 typescript-bot

Ready to merge

Mar 30 '24 05:03 Semigradsky

:hourglass_flowing_sand: Hi @matthieusieben,

It's been a few days since this PR was approved by Semigradsky, peterblazejewicz and we're waiting for a DT maintainer to give a review.

If you would like to short-circuit this wait, you can edit some of the test files in the package which verify how the .d.ts files work. This would allow the PR to be merged by you or the DT module owners after a re-review.

Mar 30 '24 05:03 typescript-bot