DefinitelyTyped icon indicating copy to clipboard operation
DefinitelyTyped copied to clipboard

Removal of import of `React` as it is no longer needed.

Open ShivamKJJW opened this issue 1 year ago • 15 comments

Reference to issue: 68394

  • [x] react-native-video. Removal of React import as it is no more required. import from * is no more valid and provides ESlint error in latest react versions.
  • [x] Test the change in your own code. (Compile and run.)
  • [ ] Add or edit tests to reflect the change.
  • [x] Follow the advice from the readme.
  • [x] Avoid common mistakes.
  • [ ] Run pnpm test <package to test>.

Select one of these and delete the others:

If changing an existing definition:

  • [ ] If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the package.json.

Error screenshot: image

ShivamKJJW avatar Jan 31 '24 08:01 ShivamKJJW

@ShivamKJJW Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ❌ Continuous integration tests have failed
  • 🕐 Only a DT maintainer can approve changes without tests

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Inactive

This PR has been inactive for 31 days — it is considered abandoned, and therefore closed!


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 68395,
  "author": "ShivamKJJW",
  "headCommitOid": "b1e122f31893bc92e8d822f349ca784e2e6be335",
  "mergeBaseOid": "6d0e970598392a8c1c62019150e4f197fadf301c",
  "lastPushDate": "2024-01-31T08:18:16.000Z",
  "lastActivityDate": "2024-01-31T17:42:49.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "react-native-video",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-native-video/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-native-video/tsconfig.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "huhuanming",
        "Nekith",
        "bananer"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 1918604354,
  "ciResult": "fail",
  "ciUrl": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/b1e122f31893bc92e8d822f349ca784e2e6be335/checks?check_suite_id=20294130726"
}

typescript-bot avatar Jan 31 '24 08:01 typescript-bot

Hey @ShivamKJJW,

:unamused: Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.

This can potentially save days of time for you!

typescript-bot avatar Jan 31 '24 08:01 typescript-bot

🔔 @huhuanming @Nekith @bananer — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

typescript-bot avatar Jan 31 '24 08:01 typescript-bot

Hey @ShivamKJJW,

😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.

This can potentially save days of time for you!

It doesn't require any change in the test cases.

ShivamKJJW avatar Jan 31 '24 08:01 ShivamKJJW

@ShivamKJJW The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

typescript-bot avatar Jan 31 '24 08:01 typescript-bot

@ShivamKJJW The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

typescript-bot avatar Jan 31 '24 08:01 typescript-bot

@ShivamKJJW The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

typescript-bot avatar Jan 31 '24 08:01 typescript-bot

@ShivamKJJW The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

typescript-bot avatar Jan 31 '24 08:01 typescript-bot

@ShivamKJJW The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

typescript-bot avatar Jan 31 '24 09:01 typescript-bot

@ShivamKJJW The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

typescript-bot avatar Jan 31 '24 09:01 typescript-bot

@ShivamKJJW The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

typescript-bot avatar Jan 31 '24 09:01 typescript-bot

I don't understand the change; you're removing the React import, which is most definitely needed to be able to use React.Component. The tsconfig change doesn't do anything for the tests either; that option does not affect checking.

jakebailey avatar Jan 31 '24 17:01 jakebailey

I was trying to find a solution to support this typescript in the project as right now it is not compatible and it throws ESLint warning as attached in the screenshot above. Can you find a solution to this? Inside any project I am able to use this type without any error with removal of React import.

Regards, Shivam K.

On Wed, 31 Jan 2024 at 11:06 PM, Jake Bailey @.***> wrote:

I don't understand the change; you're removing the React import, which is most definitely needed to be able to use React.Component. The tsconfig change doesn't do anything for the tests either; that option does not affect checking.

— Reply to this email directly, view it on GitHub https://github.com/DefinitelyTyped/DefinitelyTyped/pull/68395#issuecomment-1919588414, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFB3IKIXKAY2M5GRHFFTW4LYRJ6JZAVCNFSM6AAAAABCSTMYAWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJZGU4DQNBRGQ . You are receiving this because you were mentioned.Message ID: @.***>

ShivamKJJW avatar Jan 31 '24 17:01 ShivamKJJW

Your screenshot in the original issue isn't from ESLint (which you should not be running on node_modules anyway).

The screenshot is a TypeScript error message; it sounds more like you have multiple versions of the React types installed or something.

jakebailey avatar Jan 31 '24 17:01 jakebailey

@ShivamKJJW I haven't seen any activity on this PR in more than three weeks, and it still has problems that prevent it from being merged. The PR will be closed on Mar 1st (in a week) if the issues aren't addressed.

typescript-bot avatar Feb 23 '24 18:02 typescript-bot

@ShivamKJJW To keep things tidy, we have to close PRs that aren't mergeable and don't have activity in the last month. No worries, though — please open a new PR if you'd like to continue with this change. Thank you!

typescript-bot avatar Mar 02 '24 18:03 typescript-bot