Jake Bailey comments

Results 1408 comments of


                                            Jake Bailey

Bailout early from `isFunctionObjectType` for evolving arrays

@typescript-bot test it

Increased memory usage when creating a watch program that includes local JavaScript files in node_modules

Hm, it's a long shot, but if this happens on Windows but not on Linux, can you disable `forceConsistentCasingInFileNames` and try your test again?

Increased memory usage when creating a watch program that includes local JavaScript files in node_modules

Hm, that time is still 88 seconds, no? Aren't you expecting 62s?

Increased memory usage when creating a watch program that includes local JavaScript files in node_modules

But, the key is that memory usage is lower? Not totally seeing the change or memory increase from the above, now that I look.

Increased memory usage when creating a watch program that includes local JavaScript files in node_modules

This looks very similar to https://github.com/typescript-eslint/typescript-eslint/issues/1192 then. But that's utterly confusing because this issue is new, while the eslint one is not... Probably not _technically_ similar given the ESLint thing...

Increased memory usage when creating a watch program that includes local JavaScript files in node_modules

@reduckted When you get a chance, can you try using `"typescript": "npm:@typescript-deploys/[email protected]"` (from https://github.com/microsoft/TypeScript/pull/58299#issuecomment-2074000052) and see what happens?

Increased memory usage when creating a watch program that includes local JavaScript files in node_modules

That's even more confusing. It's a shame this repo is closed, as heap snapshots would be pretty helpful to know what's leaking...

Increased memory usage when creating a watch program that includes local JavaScript files in node_modules

Ah, I forgot that this was about the public API; too many examples that mention `tsc` and `tsc --watch` for my brain to handle 😅. Though if it's always programmatic...

Increased memory usage when creating a watch program that includes local JavaScript files in node_modules

Can you try this build? https://github.com/microsoft/TypeScript/pull/58352#issuecomment-2081888721

Allow implicit `undefined` returns when the contextual union type contains it

@typescript-bot test top400 @typescript-bot user test this @typescript-bot run dt @typescript-bot perf test this faster @typescript-bot pack this