Jake Bailey
Jake Bailey
I have personally more often seen tests in separate projects (what we do in TS, dt-tools), or one project that always builds tests with exclusions elsewhere (e.g., npmignore, what I...
What was used to generate this? Is the same tool always going to generate it? Should we exclude this from formatting checks? I'm not seeing any info about how these...
Ah found it, it's the move of `fileEntries.delete(entry);` to after `done()`, introduced in https://github.com/cthackers/adm-zip/pull/437.
I just wanted to note it here, but it would be super super awesome if (once stable) this were backported to Node 20/22 or even Node 18 if still in...
Just to give a side by side using https://github.com/remcohaszing/typescript-bug-58369: ```console $ grep -A8 'function scanJSDocCommentTextToken' ./node_modules/typescript/lib/tsc.js function scanJSDocCommentTextToken(inBackticks) { fullStartPos = tokenStart = pos; tokenFlags = 0 /* None */;...
Just to note it, you can also add `noop();` instead of `debugger;` if you want a debugger-statement free crasher.
This seems reasonable, but, it still needs some sort of test. Potentially one like those in `inconsistentErrorInEditor.ts`?
@typescript-bot test this @typescript-bot test top100 @typescript-bot user test this @typescript-bot user test tsserver @typescript-bot test tsserver top100 @typescript-bot run dt @typescript-bot perf test this @typescript-bot pack this
@typescript-bot pack this
#53082 was fixed by #55449, so this PR is no longer needed.