Jake Bailey comments

Results 1408 comments of


                                            Jake Bailey

Unable to type nested fields in a Node.js module.

The layout of this package is nonsensical; they're importing from `index.mjs` (the extension is fine and even required here!), but there is no `index.d.mts` that describes it. I have no...

Unable to type nested fields in a Node.js module.

That really isn't the problem; the problem is that there really are not any type definitions for this class. Renaming things won't help when there's no type info at at...

Use explicit extensions for imports within src

Weird, will take a look later.

Use explicit extensions for imports within src

@andrewbranch Is there a way to force this to always be required, even though we're currently being treated as CommonJS?

Use explicit extensions for imports within src

I'll whip up a lint rule and set that, thanks!

Use explicit extensions for imports within src

Sanity checked, and reverting all changes in src, running `hereby lint --fix` and `dprint` nets the right result, missing only the manual changes for using `export *` for the unit...

Make TypeScript itself ESM-only, made possible by require(ESM)

This has been rebased now that we're using extensions on main, condensing this down to a pretty small change (though there's still stuff not working).

Make TypeScript itself ESM-only, made possible by require(ESM)

There are still a bunch of TODOs, but this is actually green! Wow!

isolatedDeclarations should not have warning for functions that have no return statements

This error is intentional; a function without a return may not always be `void`. ```ts declare function fail(): never; export function f() { fail(); } export const g = ()...

isolatedDeclarations should not have warning for functions that have no return statements

#58331 is indiscriminate in what it affects; if we want to allow this for function declarations only, that may be possible, but it sure seems like an extra inconsistency just...