TypeScript icon indicating copy to clipboard operation
TypeScript copied to clipboard

Fix for Issue 61081

Open JulianTaub opened this issue 10 months ago • 5 comments

Fixes #61081

JulianTaub avatar Feb 19 '25 04:02 JulianTaub

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

typescript-bot avatar Feb 19 '25 04:02 typescript-bot

@JulianTaub please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

JulianTaub avatar Feb 19 '25 04:02 JulianTaub

@typescript-bot I saw that CI/ format check failed. I just formatted the file locally and I can push it up and add it to the pull request after the request has been reviewed.

JulianTaub avatar Feb 19 '25 04:02 JulianTaub

FWIW you do not need tests for this kind of change; it's honestly worse to write tests for these comments because updating them later will mean having to update tests to just copy the same text a second time.

jakebailey avatar Feb 22 '25 00:02 jakebailey

Thanks @jakebailey, I understand. I can take out my 2 tests if necessary.

Also, I just pushed up 3 baseline/reference test files that had failed after reformatting.

JulianTaub avatar Feb 23 '25 01:02 JulianTaub

Ha, I didn't notice my own comment from before; at least I'm consistent. But, please do remove all changes except those in es5.d.ts.

jakebailey avatar Jun 30 '25 23:06 jakebailey

Thanks, @jakebailey. I just removed everything except for es5.d.ts and 2 fourslash test baseline files that the doc changes affected.

JulianTaub avatar Jul 07 '25 02:07 JulianTaub